Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] linuxtv-dvb-install-destdir.patch



Okay, so now that I see the packages are functional, let's get
slowly into the patch queue - quite a number coming up ;-)

* linuxtv-dvb-1.1.0 build-2.4 make install
doing `make install` will effectivly execute this:
    -su -c "mkdir -p $(DEST); cp -v $(obj-m) $(DEST); \
         depmod -a ; sh ../MAKE DEV-DVB.sh"

now that is awfully wrong for an rpm install to a staging area!
No "su" please, and depmod should be at rpm install time, not
packaging time.

The patch puts in a `make install-destdir` target which does
also handle the usual DESTDIR variable for the staging area.

Btw, when not downloading the dvb-ttpci firmware, there is a
*.txt file being put into the modules area which makes depmod
unhappy but it seems to get over with it. Can that be cut out
from the original `install`? Anyway, at the moment, the rpm
_includes_ the firmware - is that correct measure?

Additionally, I had seen unresolved symbols (from depmod)
about bt8xx IIRC but the current modules.dep does not give
me a hint as to what that were back then. May be I'll check
later into this.

-- cheers, guido

--- build-2.4/Makefile.orig	2004-01-26 11:47:03.000000000 +0100
+++ build-2.4/Makefile	2004-02-13 21:21:31.000000000 +0100
@@ -87,6 +87,8 @@
 	@echo
 	@echo --------------------------------------------------------------------------------------
 	-su -c "mkdir -p $(DEST); cp -v $(obj-m) $(DEST); depmod -a ; sh ../MAKEDEV-DVB.sh"
+install-destdir :
+	mkdir -p $(DESTDIR)$(DEST); cp -v $(obj-m) $(DESTDIR)$(DEST)
 
 clean::
 	find . -type l -exec rm {} \;

Home | Main Index | Thread Index