[linux-dvb] Re: libdvb 0.5.4 patches

[Guido Draheim <guidod-2003-@gmx.de>]

Marcus Metzler wrote:
> Guido Draheim writes:
>  > [1  <text/plain; us-ascii (7bit)>]
>  > I had sent the patches to metzlerbros (rjkm) but so far no reply. So I
>
> Wrong brother.
okay then ;-)
>  > think it is best to put them on linux-dvb message archive for other people
>  > who go to make rpm packages of libdvb - these patches might help you. ;-)
>  > 
> Why should I patch all this? (except for
>
>  > --- dvb-mpegtools/Makefile.orig	2004-01-28 20:44:27.000000000 +0100
>  > +++ dvb-mpegtools/Makefile	2004-02-12 18:52:00.000000000 +0100
>  > @@ -61,7 +61,7 @@
>  >  	install -m 755 audiofilter $(PREFIX)/bin/
>  >  	install -m 755 dvb-mpegtools_main $(PREFIX)/bin/
>  >  	install -m 755 dvbaudio $(PREFIX)/bin/
>  > -	install -m 755 dvb_show_image $(PREFIX)/bin/
>  > +	install -m 755 show_dvb_image $(PREFIX)/bin/
>  >  	install -m 755 dia $(PREFIX)/bin/
>  >  	for f in $(LINKS); do\
>  >  		ln -sf $(PREFIX)/bin/dvb-mpegtools_main $(PREFIX)/bin/$$f ;\
>
> which I already did.)
>
> No criticism, I just need a reason.
>
> Marcus

my initial mail read like this, perhaps that can clarify things:


Guido Draheim wrote:
> heya,
>
> I'm build dvb modules for mandrake and pushing dvb tools along,
> including dvb-mpegtools or libdvb as they are called now. Here
> are some things I came to notice
>
> - there is no COPYING in the tarball
> - there is no contact email in the tarball
> - the `make install` stage does not use DESTDIR,
>     just override of PREFIX does it for installstage
> - lastest make install fails due to bug in dvb-modules/Makefile
>      where dvb_show_image != show_dvb_image
> - formerly I was installing header files in a different place
>      but now libdvb installs them before and elsewhere. It is
>      certainly a Bad Idea to push them just as toplevel entries
>      to /usr/include/*.h  with names like "channel.h"
> - I did install pkgconfig .pc files to add the includepath
>      dynamically to only those projects incorporating libdvb
> - personally, I did use a patch in the past to make dvb-mplex
>      recognize symlink-calls with a "dvb_*" prefix. Not everyone
>      would like generics like "streamtype" and "split_mpg" to
>      be taken for dvb
>

WDYT? ;-) cheers,
-- guido                                  http://google.de/search?q=guidod
GCS/E/S/P C++/++++$ ULHS L++w- N++@ s+:a d(+-) r+@>+++ y++ 5++X- (geekcode)



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.