[linux-dvb] Re: linuxtv-dvb-apps-1.1.0 install patches

[Johannes Stezenbach <js@convergence.de>]

Guido Draheim wrote:
> [make install & DESTDIR stuff]

Very nice. Thanks!

> Furthermore, I did add install-etc extra targets that do not only
> handle bindir files - there are some files like *.rc5 and the
> series of channels.conf-* that should be present in the non-source
> installation to be usable by users. At the moment I did just push
> them to $(sysconfdir)/dvb/* which might not be the best place but
> at the same time it makes it easy to tell users where to look for
> them in their rpm installation.

IMHO that's the wrong place. These files should either go
to /usr/share/dvb/ or /usr/lib/dvb/, or maybe even
/usr/share/docs/dvb/exaples/.

I will apply your patch anyway (because I don't care that
much about LSB compliance), but a follow-up patch that
corrects the locations will gladly be accepted.

> --- test/Makefile.orig	2004-02-13 21:40:20.000000000 +0100
> +++ test/Makefile	2004-02-13 21:42:11.000000000 +0100
> @@ -35,3 +35,8 @@
>  clean:
>  	rm -f $(TARGETS) *.o
>  
> +install:
> +	test "$(bindir)/" != "/"
> +	mkdir -p $(DESTDIR)$(bindir)/
> +	for i in $(TARGETS) ; do cp $$i $(DESTDIR)$(bindir)/dvb_$$i ; done
> +

I'm not sure if the test programs are useful for normal users.
I would prefer not to install them. People interested enough
in DVB to understand what they do would fetch the source tarball
anyway, wouldn't they?

Johannes


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.