Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: linuxtv-dvb-apps-1.1.0 install patches




Johannes Stezenbach wrote:
Guido Draheim wrote:

[make install & DESTDIR stuff]

Very nice. Thanks!


Furthermore, I did add install-etc extra targets that do not only
handle bindir files - there are some files like *.rc5 and the
series of channels.conf-* that should be present in the non-source
installation to be usable by users. At the moment I did just push
them to $(sysconfdir)/dvb/* which might not be the best place but
at the same time it makes it easy to tell users where to look for
them in their rpm installation.

IMHO that's the wrong place. These files should either go
to /usr/share/dvb/ or /usr/lib/dvb/, or maybe even
/usr/share/docs/dvb/exaples/.

I will apply your patch anyway (because I don't care that
much about LSB compliance), but a follow-up patch that
corrects the locations will gladly be accepted.
well, I can make up all the needed patches, I just want to be
sure that a package for 1.1.0 does the same as later packs.

Since you do not care that much I'd say to choose again a
*single* place - and in that case it would be $datadir/dvb/
i.e. /usr/share/dvb/ in a package install. Agreed?


--- test/Makefile.orig	2004-02-13 21:40:20.000000000 +0100
+++ test/Makefile	2004-02-13 21:42:11.000000000 +0100
@@ -35,3 +35,8 @@
clean:
	rm -f $(TARGETS) *.o

+install:
+	test "$(bindir)/" != "/"
+	mkdir -p $(DESTDIR)$(bindir)/
+	for i in $(TARGETS) ; do cp $$i $(DESTDIR)$(bindir)/dvb_$$i ; done
+

I'm not sure if the test programs are useful for normal users.
I would prefer not to install them. People interested enough
in DVB to understand what they do would fetch the source tarball
anyway, wouldn't they?

Almost. What if there are problems with a card and the preinstalled
drivers (either from distro or 3rdparty package like mine). One could
have a number of binaries at hand that can help in the process - and
which do not need 'em do configure the kernel-source or even get it
from distro cd.

A number of options come to my mind:
- build a linuxtv-dvb-apps-devel package (I'll probably do that anyway).
- move these test binaries to /usr/sbin/ (may be the better place)
- or even into some /usr/lib/dvb/bin/ (to hide it but keep them around)

WDYT?
-- guido                                  http://google.de/search?q=guidod
GCS/E/S/P C++/++++$ ULHS L++w- N++@ s+:a d(+-) r+@>+++ y++ 5++X- (geekcode)



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.



Home | Main Index | Thread Index