[linux-dvb] Re: linuxtv-dvb-apps-1.1.0 install patches

[Guido Draheim <guidod-2003-@gmx.de>]

Johannes Stezenbach wrote:
> Guido Draheim wrote:
>
> > Index: test/Makefile
> > ===================================================================
> > RCS file: /cvs/linuxtv/dvb-apps/test/Makefile,v
> > retrieving revision 1.3
> > diff -u -r1.3 Makefile
> > --- test/Makefile	14 Feb 2004 22:04:51 -0000	1.3
> > +++ test/Makefile	14 Feb 2004 23:36:24 -0000
> > @@ -37,4 +37,7 @@
> > 	rm -f $(TARGETS) *.o
> >
> > install:
> > +	test "$(libdir)/" != "/"
> > +	mkdir -p $(DESTDIR)$(libdir)/dvb/test
> > +	cp $(TARGETS) $(DESTDIR)$(libdir)/dvb/test/
>
> I still think installing them is a bad idea.
Well, packagers will still tend to install them, just by the rule that
`what gets "made" by default, should get "made install"ed by default`.

Here is a patch that takes it out of the `make install` path and puts
in a special `make install-test` target - that will ensure that users
and packagers install the test binaries into the same path everywhere.
Kinda standardization in the mood of "*sigh* I think installing them
is a bad idea but if you really want to then put them here" ;-)

cheers,
-- guido                                  http://google.de/search?q=guidod
GCS/E/S/P C++/++++$ ULHS L++w- N++@ s+:a d(+-) r+@>+++ y++ 5++X- (geekcode)
Index: test/Makefile
===================================================================
RCS file: /cvs/linuxtv/dvb-apps/test/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- test/Makefile	14 Feb 2004 22:04:51 -0000	1.3
+++ test/Makefile	15 Feb 2004 07:08:02 -0000
@@ -38,3 +38,8 @@
 
 install:
 
+install-test:
+	test "$(libdir)/" != "/"
+	mkdir -p $(DESTDIR)$(libdir)/dvb/test
+	cp $(TARGETS) $(DESTDIR)$(libdir)/dvb/test/
+