[linux-dvb] Re: [PATCH] dvb-ttpci+budgetpatch integrated v33

[emard@softhome.net]

> > +	if(budgetpatch == 0)
> > +	{
> > +		printk("av7110.c: vpeirq() called while budgetpatch disabled!"
> > +			" check saa7146 IER register\n");
> > +		return;
> > +	}

Excuse my ancient style of braces, I must convert myself to the kernel's
format

> kernel people like this style better:
> 	if (...) {
> 		...
> 	}

I'm installing EMACS at once

> > +	if (newdma > olddma) {	/* no wraparound, dump olddma..newdma */
> > +		dvb_dmx_swfilter_packets(&budget->demux1, mem + olddma, (newdma - olddma) / 188);
> > +	} else {		/* wraparound, dump olddma..buflen and 0..newdma */
> 
> kernel people don't like superflous braces, use:
> 	if (...)
> 		...;
> 	else {

OK!

> > +	struct dmx_frontend	hw_frontend, hw_frontend1;
> > +	struct dmx_frontend	mem_frontend, mem_frontend1;
> 
> hw_frontend1 and mem_frontend1 seem to be unused

Oh, yes, as demux1 works perfectly without own frontend I
better remove those from struct too

> (A lot of lines use spaces for indentation instead of tabs, and some
> have white space at eol; not important but I don't like it).

OK. let me run this in emacs to beautify the code

> 
> Otherwise this seems ready for merging, isn't it?

Yes, version 33 survived a stress test script of continuos
insertion and removal of dvb-ttpci

Emard