[vdr] Re: vdr with vdr-xine : "Restart" does not restart VDR

[Darren Salt <linux@youmustbejoking.demon.co.uk>]

I demand that Nicolas Huillard may or may not have written...

> Reinhard Nissl a écrit :
>> Nicolas Huillard wrote:
>>> The problem : when I use the VDR menu to restart VDR (in order to reload
>>> the DVB kernel modules), VDR does no stop, with the following syslog
>>> trace :
[snip]
> The problem was patch-related : Darren Salt's Debian packages come with
> a lot of patches, and I didn't check if they were all deapplied. I
> thought they were, but it was not the case (Debian packagers beware :
> make clean before modifying 00list, or something like this).

  $ debuild clean

will do it.

> The problem come from one of the following patches (Darren Salt's 1.3.12) :

[snip]
> #09_reload

This one. I can cause the same problem here...

Memory says that 1.3.12 doesn't have the Exit label in vdr.c:main() so, with
the above patch applied ('dpatch-edit-patch 09_reload'), the following
UNTESTED patch should work:

--- vdr.c~
+++ vdr.c
@@ -549,6 +549,7 @@
     while (!Interrupted && !RestartRequest) {
       // Handle emergency exit
       if (cThread::EmergencyExit()) {
+         Interrupted = SIGUSR1;
          esyslog("emergency exit requested - shutting down");
          break;
          }

For 1.3.14, you can replace that 'break;' with 'goto Exit;'. This definitely
works, and I'll release -2 later - I'm currently trying to fix one of the
don't-reload conditions in this patch...

-- 
| Darren Salt | nr. Ashington, | d youmustbejoking,demon,co,uk
| Debian,     | Northumberland | s zap,tartarus,org
| RISC OS     | Toon Army      | @
|   Retrocomputing: a PC card in a Risc PC

This is a good day for overcoming obstacles. Try a steeplechase.