[linux-dvb] Re: Volume control broken since cvs 20030424

[Tobias Bratfisch <tobias.dvb@bratfisch.net>]

Hi!

> > 	* driver/av7110/av7110.c: enable msp3400 volume control for vendor
> > 	id 0x13c2, too. Reported by Andreas Kool <akool@akool.de>

There IMHO the fault is located (around line 4970 in cvs-DVB):

                /**                                                                     
                 * some special handling for the Siemens DVB-C card...                  
                 */
                if ((av7110->saa->device->subsystem_vendor == 0x110a) ||
                    (av7110->saa->device->subsystem_vendor == 0x13c2)) {
                        if (i2c_writereg(av7110, 0x80, 0x0, 0x80) == 1) {
                                i2c_writereg(av7110, 0x80, 0x0, 0);
                                printk("av7110: DVB-C analog module detected,"
                                       "initializing MSP3400\n");
		<snip/>

	        } else
                  av7110->adac_type = DVB_ADAC_TI;
	
The "else"-statement is the problem! 24.03. Before it looked like this:

                        /**                                                                     
                        * some special handling for the Siemens DVB-C card...                  
                        */
                        if (i2c_writereg(av7110, 0x80, 0x0, 0x80)==1) {
                                i2c_writereg(av7110, 0x80, 0x0, 0);
                                printk("av7110: DVB-C analog module detected,"
                                       "initializing MSP3400\n");
			<snip/>

                        } else
                          av7110->adac_type = DVB_ADAC_NONE;

So with the new code the DVB-S cards which have NO MSP3400 get automatically 
av7110->adac_type = DVB_ADAC_TI whether they have it or not.
So NO card can have av7110->adac_type = DVB_ADAC_NONE !

Am I right?

rgds
Tobias Bratfisch


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.