[linux-dvb] Re: Volume control broken since cvs 20030424

[Are Årseth <are@arseth.org>]

Artur Skawina sa:
>> The "else"-statement is the problem! 24.03. Before it looked like this:
>
>>                         } else
>>                           av7110->adac_type = DVB_ADAC_NONE;
>>
>> So with the new code the DVB-S cards which have NO MSP3400 get
>> automatically
>> av7110->adac_type = DVB_ADAC_TI whether they have it or not.
>> So NO card can have av7110->adac_type = DVB_ADAC_NONE !
>>
>> Am I right?
>
> yes, sort of. iirc before there was no 'else' clause at all.
> then the DVB_ADAC_NONE setting got added, which together with
> the DVB-C detection change that triggers not only for DVB-C, but
> also for DVB-S, caused loss of audio control for DVB-S1.3.
> I reported this to Holger, together w/ a patch that changed
> DVB_ADAC_NONE back to DVB_ADAC_TI (which got my 1.3 card working)
> while suggesting the else clause was suspect. He applied the
> patch, apparently assuming that every AV7110 could be controlled
> using the ADAC_TI approach.
> As it is, currently audio control does work for 1.3, does not for
> 1.5(1.6?) and newer according to this thread -- i still think the
> detection code is at fault, but as i don't have any DVB-C cards
> i can't fix/test this here.
> Are the cards really indistinguishable based on the pci ids?

For what it's worth here is the pci space for my Hauppage DVB-S 2.1:
lspci -vv -xxx -s 00:0c
00:0c.0 Multimedia controller: Philips Semiconductors SAA7146 (rev 01)
        Subsystem: Technotrend Systemtechnik GmbH: Unknown device 0003
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B-
        Status: Cap- 66Mhz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
        Latency: 64 (3750ns min, 9500ns max)
        Interrupt: pin A routed to IRQ 12
        Region 0: Memory at e9102000 (32-bit, non-prefetchable) [size=512]
00: 31 11 46 71 06 00 80 02 01 00 80 04 00 40 00 00
10: 00 20 10 e9 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 c2 13 03 00
30: 00 00 00 00 00 00 00 00 00 00 00 00 0c 01 0f 26
40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
80: 00 00 00 80 00 00 00 80 00 00 00 80 00 00 00 80
90: 00 00 00 80 00 00 00 80 00 00 00 80 00 00 00 80
a0: 00 00 00 80 00 00 00 80 00 00 00 80 00 00 00 80
b0: 00 00 00 80 00 00 00 80 00 00 00 80 00 00 00 80
c0: 00 00 00 80 00 00 00 80 00 00 00 80 00 00 00 80
d0: 00 00 00 80 00 00 00 80 00 00 00 80 00 00 00 80
e0: 00 00 00 80 00 00 00 80 00 00 00 80 00 00 00 80
f0: 00 00 00 80 00 00 00 80 00 00 00 80 00 00 00 80

-- 
Mvh. Are Årseth
| are@arseth.org | aaarseth@atmel.com | Tlf: 73 98 49 58 | Mob: 41 00 05 48


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.