[linux-dvb] Re: TDA10045H woes -- argh

[Andrew de Quincey <adq_dvb@lidskialf.net>]

On Wednesday 18 June 2003 00:25, Robert Schlabbach wrote:
> From: "Ben McKeegan" <ben@mckeegan.org>
>
> > I've tried running with the debug option and it appears to be looping,
> > continually calling tda_10045h_init, and never starts uploading the
> > firmware.  I stuck in a few extra debug output lines to isolate where
> > the problem was occuring.  It seems to be in the section of code that
> > disables the MC44BC374C:
>
> Ben, could you take a look at the "tin box" on your card and copy all
> markings you find on it? From what you describe it sounds like there is no
> remodulator on you card. Andrew's and my card have the "TDM1316L" tuner on
> it, where the "M" marks it as being a model with a remodulator, though that
> part is completely unused in the card design. There is also a "TD1316L"
> model, which does not have a demodulator.

Doh! Try THIS patch which actually compiles.
Index: linux/drivers/media/dvb/frontends/tda10045h.c
===================================================================
RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/frontends/tda10045h.c,v
retrieving revision 1.2
diff -u -p -r1.2 tda10045h.c
--- linux/drivers/media/dvb/frontends/tda10045h.c	17 Jun 2003 12:01:33 -0000	1.2
+++ linux/drivers/media/dvb/frontends/tda10045h.c	18 Jun 2003 08:56:10 -0000
@@ -370,11 +370,7 @@ int tda10045h_init(struct dvb_i2c_bus *i
 	tuner_msg.buf = disable_mc44BC374c;
 	tuner_msg.len = sizeof(disable_mc44BC374c);
 	if (i2c->xfer(i2c, &tuner_msg, 1) != 1) {
-		if (i2c->xfer(i2c, &tuner_msg, 1) != 1) {
-			if (firmware)
-				vfree(firmware);
-			return -EIO;
-		}
+	        i2c->xfer(i2c, &tuner_msg, 1);
 	}
 	tda10045h_disable_tuner_i2c(i2c);