[linux-dvb] Re: dvb-kernel bugs

[Wolfgang Thiel <w-thiel@gmx.net>]

On Mon, Nov 17, 2003 at 07:05:05PM +0100, Johannes Stezenbach wrote:
> Wolfgang Thiel wrote:
> > 
> > this morning's dvb-kernel CVS has at least two problems:
> > twice, dprintk has been inserted at a wrong place (before declaring
> > the variables of the routine, which follow later)
> 
> Most of us use gcc-3.3.2 which is more ISO-C99 compliant than older
> gccs. Thus we usually don't notice those problems.
> Please send a patch or at least your compiler's error messages.
>
I'm still using 2.95. I'll attach a dif: it's trivial.

> > More serious: the 2.6B support for skystar2 seems to be broken as
> > well.
> 
> What exactly means broken?
>
Hmh: that's a problem. Perhaps, it is as broken as it used to be?
If anything goes wrong (like the wind blowing the dish away), I have
to restart the driver: if it was szap -r and catting /dev/dvb/ad..
to mplayer, this doesn't work anymore: no data (restarting the pipe
doesn't help either), using my dvbts 0x2000, which is supposed to dump
the whole transponder to mplayer isn't working either: Perhaps, I
should checkout mplayer and ffmpeg more often...

> > Well: the skystar2 driver isn't loaded by default either. Bug or
> >       feature?
> 
> IMHO the insmod.sh script loads too many drivers to be useful.
> We should have something better.
>
Agreed. But I don't see how to do this.
At the moment, everything is loaded, but not skystar2 (even the FF-patched-
to-budget cards: how many users will that be?)


Wolfgang

> Johannes
> 
> 
> -- 
> Info:
> To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.
> 
diff -urN dvb-kernel.orig/build-2.4/insmod.sh dvb-kernel-031116/build-2.4/insmod.sh
--- dvb-kernel.orig/build-2.4/insmod.sh	2003-11-12 18:22:37.000000000 +0000
+++ dvb-kernel-031116/build-2.4/insmod.sh	2003-11-16 19:40:13.000000000 +0000
@@ -28,6 +28,7 @@
 	insmod ./dvb-ttpci-budget-ci.o
 	insmod ./dvb-ttpci-budget-av.o
 	insmod ./dvb-ttusb-budget.o
+	insmod ./skystar2.o
 	echo
 	;;
     debug)
@@ -53,11 +54,12 @@
 	insmod ./dvb-ttpci-budget-ci.o
 	insmod ./dvb-ttpci-budget-av.o
 	insmod ./dvb-ttusb-budget.o
+	insmod ./skystar2.o debug=1
 	echo
 	;;
     unload)
 	echo -n -e "Deleting av7110 modules from kernel"
-	rmmod dvb-ttpci dvb-ttpci-budget dvb-ttpci-budget-av \
+	rmmod skystar2 dvb-ttpci dvb-ttpci-budget dvb-ttpci-budget-av \
 		dvb-ttpci-budget-ci \
 		dvb-ttusb-budget ttpci-eeprom \
 		ves1x93 alps_tdmb7 alps_tdlb7 stv0299 ves1820 \
diff -urN dvb-kernel.orig/linux/drivers/media/dvb/b2c2/skystar2.c dvb-kernel-031116/linux/drivers/media/dvb/b2c2/skystar2.c
--- dvb-kernel.orig/linux/drivers/media/dvb/b2c2/skystar2.c	2003-11-12 18:22:38.000000000 +0000
+++ dvb-kernel-031116/linux/drivers/media/dvb/b2c2/skystar2.c	2003-11-16 19:26:54.000000000 +0000
@@ -2288,8 +2288,8 @@
 	    case FE_DISEQC_SEND_BURST:
 	    {
 		u8 count;
-		dprintk("%s: FE_SEND_BURST ", __FUNCTION__);
 		fe_sec_mini_cmd_t b = (fe_sec_mini_cmd_t) arg; 
+		dprintk("%s: FE_SEND_BURST ", __FUNCTION__);
 		switch ( b )		
 		{   
 		    case SEC_MINI_A:
diff -urN dvb-kernel.orig/linux/drivers/media/dvb/bt8xx/bt878.c dvb-kernel-031116/linux/drivers/media/dvb/bt8xx/bt878.c
--- dvb-kernel.orig/linux/drivers/media/dvb/bt8xx/bt878.c	2003-11-01 09:33:06.000000000 +0000
+++ dvb-kernel-031116/linux/drivers/media/dvb/bt8xx/bt878.c	2003-11-16 19:25:52.000000000 +0000
@@ -214,9 +214,9 @@
 void bt878_start(struct bt878 *bt, u32 controlreg, u32 op_sync_orin,
 		u32 irq_err_ignore)
 {
-	dprintk("bt878 debug: bt878_start (ctl=%8.8x)\n", controlreg);
 	u32 int_mask;
 
+	dprintk("bt878 debug: bt878_start (ctl=%8.8x)\n", controlreg);
 	/* complete the writing of the risc dma program now we have
 	 * the card specifics
 	 */