[linux-dvb] Re: Driver in 2.6.8-rc2 and DVB-C

[Johannes Stezenbach <js@convergence.de>]

Johannes Stezenbach wrote:
> Kenneth Aafløy wrote:
> > On Tuesday 27 July 2004 02:39, Matthias Rieber wrote:
> > > Hi,
> > >
> > > I'm switching from my old kernel 2.4 installation to kernel 2.6. After
> > > loading the modules ves1820 and dvb-ttpci I was able to start vdr. It
> > > tuned the first channel, good, but when I switch to the next channel I
> > > got audio, but now picture? I had to restart the vdr, then it tunes the
> > > channel that was selected before I left vdr, but with picture. I tried
> > > to set adac=-1 as describe in the kernel documentation, but it has no
> > > use.
> > >
> > > Could this a VDR problem? Or it's the driver? Forget I to load a certain
> > > module? Has somebody else seen this behaviour?
> > 
> > It could be some changes that was done by some kernel maintainer a while ago, 
> > which is included in this release. The possible offending changeset in bk is:
> > 
> > http://linux.bkbits.net:8080/linux-2.6/cset%401.1784.20.11?nav=index.html|
> > src/.|src/drivers|src/drivers/media|src/drivers/media/dvb|
> > src/drivers/media/dvb/ttpci|related/drivers/media/dvb/ttpci/av7110_av.c
> > 
> > We should really try to get those changes back here for testing.
> 
> There's definitely something broken. vdr-1.3.12 spits out
>   ERROR (transfer.c,110): Operation not permitted
> endlessly (result of PlayVideo()).

It seems Al Viro broke dvb_usercopy():

--- dvb_functions.c.orig	2004-07-28 20:39:23.000000000 +0200
+++ dvb_functions.c	2004-07-28 20:21:23.000000000 +0200
@@ -36,7 +36,7 @@ int dvb_usercopy(struct inode *inode, st
         /*  Copy arguments into temp kernel buffer  */
         switch (_IOC_DIR(cmd)) {
         case _IOC_NONE:
-                parg = NULL;
+                parg = (void *) arg;
                 break;
         case _IOC_READ: /* some v4l ioctls are marked wrong ... */
         case _IOC_WRITE:

Johannes