[linux-dvb] Re: [PATCHES] Frontend kernel i2c conversion.

[Kenneth Aaflĝy <lists@kenneth.aafloy.net>]

On Wednesday 04 August 2004 13:36, Andreas Büsching wrote:
[snip]
> > dvbfe_mt352: Trying to attach to adapter 0x10005:bt878 #0 [hw].
> > dvbfe_mt352: Setup for Avermedia 771.
>
> ... some new information has just arrived ...
>
> I started debugging the mt352 module (what is quite difficult as I do
> not know that much about dvb und i2c kernel stuff). What I found out is
> that the mt352_command function is never called, what results in a
> messing call to dvb_register_frontend[_new], which seems to be very
> important.
>
> Maybe this will help to find the problem. I will do everything I can to
> help you find the bug/problem.

I'm pretty sure I checked that the bt driver had a call to 
i2c_clients_command, but now I can find the changes for either the mt352 or 
dvb-bt in any of my trees, hmm. I've attached a patch which should be what 
you need, the extra include <moduleparam.h> is some unrelated changes for 
kernel < 2.6.7.

Thanks for testing,
Kenneth
Index: linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c
===================================================================
RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c,v
retrieving revision 1.22
diff -u -r1.22 dvb-bt8xx.c
--- linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c	30 Jul 2004 00:28:26 -0000	1.22
+++ linux/drivers/media/dvb/bt8xx/dvb-bt8xx.c	4 Aug 2004 12:10:33 -0000
@@ -21,6 +21,7 @@
 
 #include <asm/bitops.h>
 #include <linux/module.h>
+#include <linux/moduleparam.h>
 #include <linux/init.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
@@ -393,6 +394,8 @@
 	
 	bt878_start(card->bt, card->gpio_mode, card->op_sync_orin, card->irq_err_ignore);
 
+	i2c_clients_command(card->i2c_adapter, FE_REGISTER, card->dvb_adapter);
+
 	return 0;
 }
 
@@ -513,6 +516,9 @@
 		
 		dprintk("dvb_bt8xx: unloading card%d\n", card->bttv_nr);
 
+		i2c_clients_command(card->i2c_adapter, FE_UNREGISTER,
+				    card->dvb_adapter);
+
 		bt878_stop(card->bt);
 		tasklet_kill(&card->bt->tasklet);
 		dvb_net_release(&card->dvbnet);