[linux-dvb] Re: [PATCH] dvb_bt8xx: sub_device

[Michael Hunold <hunold@convergence.de>]

Hello Kenneth,

(Gerd, there is a slight problem with the bttv part of the driver, 
please see below)

On 08/13/04 15:52, Kenneth Aafløy wrote:
> I've attached a patch which converts the dvb-bt8xx driver to the bttv 
> sub_device interface, and thus makes it work with the converted frontend 
> drivers.
Thank you very much for your work!

Your patch works just fine, although I had to convert the Twinhan 
DST-frontend-driver to kernel-i2c by myself. ;-)

> A previous version was tested and confirmed working by Andreas Büsching, 
> thanks a lot for this, but I've made some modifications after this, to avoid 
> making modules with symbol version differences, and a fix for registering 
> with the bttv bus (Andreas, you should not need to modify the video4linux 
> snapshot now).
I suggest that you simply check in your patch into CVS, so I can commit 
my DST frontend stuff as well.

I encountered the following problem with the bttv i2c code:

 For the Twinhan card, apparently the "bttv_i2c_adap_hw_template" is 
used. Unfortunately, it does not contain ".client_unregister = 
detach_inform" (like bttv_i2c_adap_sw_template), so when the DST 
frontend module unregisters, detach_inform() and bttv_i2c_info() are 
*not* called and the FE_UNREGISTER is not dispatched. I caught this 
problem because I check if FE_UNREGISTER has been dispatched before 
unregistering the frontend.

I simply added the above call to the struct and it works just fine. 
Gerd, are there any problems why ".client_unregister" is not set for
"bttv_i2c_adap_hw_template"?

> Kenneth
CU
Michael.