[linux-dvb] Re: Bug in software demux still in 2.6.10

["Valsecchi Patrick" <patrick.valsecchi@nagra.com>]

Hello,

That won't work in every case. Immagine the first two packets you get are:
  - middle of section A  (no PUSI)
  - end of section A and start of section B (with PUSI pointing to the start of the second section)

In this case, with your patch, you'll receive a garbage section consisting of the end of section A. Basically because tsfeedp is incemented and the use=0 condition is not raised when the second packet arrives.

If you want to go this way, I think "use" should be in the feed stucture. It should not be a paramater. You initialize it to 0 when the demux is started and you put it to one as soon as you see a PUSI.

Patrick

> -----Original Message-----
> From: linux-dvb-bounce@linuxtv.org
> [mailto:linux-dvb-bounce@linuxtv.org]On Behalf Of emard@softhome.net
> Sent: Tuesday, January 04, 2005 3:17 PM
> To: linux-dvb@linuxtv.org
> Subject: [linux-dvb] Re: Bug in software demux still in 2.6.10
> 
> 
> HI
> 
> I just browsed the code and saw that those if's make
> it step out of normal procedure, it might be not
> nice to call them this way, so I'd propose a this
> kind of fix. As I currently have (again) hardware 
> failure I can't test it - can you verify if this
> patch would fix your issue in the same way as your
> original proposal does?
> 
> Emard
>