[linux-dvb] Re: [PATCH] dvb-ttpci+budgetpatch integrated v33

[Johannes Stezenbach <js@linuxtv.org>]

emard@softhome.net wrote:
> See I forgot to free demux, structures here's an update
> version

There are still a few nits:

> +	if(budgetpatch == 0)
> +	{
> +		printk("av7110.c: vpeirq() called while budgetpatch disabled!"
> +			" check saa7146 IER register\n");
> +		return;
> +	}

kernel people like this style better:
	if (...) {
		...
	}

> +	if (newdma > olddma) {	/* no wraparound, dump olddma..newdma */
> +		dvb_dmx_swfilter_packets(&budget->demux1, mem + olddma, (newdma - olddma) / 188);
> +	} else {		/* wraparound, dump olddma..buflen and 0..newdma */

kernel people don't like superflous braces, use:
	if (...)
		...;
	else {

> +	struct dmx_frontend	hw_frontend, hw_frontend1;
> +	struct dmx_frontend	mem_frontend, mem_frontend1;

hw_frontend1 and mem_frontend1 seem to be unused

(A lot of lines use spaces for indentation instead of tabs, and some
have white space at eol; not important but I don't like it).

Otherwise this seems ready for merging, isn't it?

Johannes