[linux-dvb] Re: [PATCH] dvb-ttpci+budgetpatch integrated late patch 08

[Johannes Stezenbach <js@linuxtv.org>]

Hi Emard,

emard@softhome.net wrote:
> Like before, I corrected few flaws of myself, 
> moved vpeirq to be present only in budgetpatch 
> mode and added stopping of the tasklets etc, all 
> this to fix stability for insmod/rmmod 

OK, I comitted this part.

> The beautification fix brought up (again) dvb_net 
> issue, the dvb_net string "dvb" I think has to be
> of the right length when we overwrite it
> with dvb0_0. Otherwise removing of the network
> interfaces sometimes wants to hang.
...
> -	net = alloc_netdev(sizeof(struct dvb_net_priv), "dvb", dvb_net_setup);
> +	/* "dvb0_0" string must in advance be of the right length */
> +	net = alloc_netdev(sizeof(struct dvb_net_priv), "dvb0_0", dvb_net_setup);

I dropped this hunk. struct net_device has name[IFNAMSIZ], and that
field isn't used before register_netdev() is called. I don't see
what problem your change could fix.

Johannes