[vdr] Re: [linux-dvb] lockups with NEWSTRUCT

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Holger Waechtler wrote:
> 
> Thanks, for spotting this out!
> 
> Klaus: Could you please apply this fix?
> 
> thanks,
> 
> Holger

I have updated the CVS NEWSTRUCT driver and applied the fix suggested below.
The first impression was very good: no more dropouts and no ARM crashes.

Then I started a recording on my second DVB card, and suddenly I had dropouts
on my _first_ DVB card, which wasn't even involved in the recording.

When I replayed the recording there were no such dropouts, so the second
card actually recorded just fine (note that my second DVB card is a budget card).

Bottom line: dropout and ARM crash problem solved, new problem with dropouts
on first DVB card while recording on second card (I tried this several times
and it was always reproducable).

Klaus

> Jeremy Hall wrote:
> > I have found it.
> >
> > In eit.c, look at where a new section filter is created.  I believe we
> > have discussed this before, it is improper initialization of the filter, I
> > seem to remember something about a mode or something not being
> > initialized.
> >
> > The recommended fix was
> >
> > memset(&sctFilterParams,0,sizeof(sctFilterParams));
> >
> > instead of doing filter and mask separately.  Probably somebody long ago
> > copied some code from somewhere that did it this way and didn't think
> > about the API changes.
> >
> > _J
> >
> > In the new year, Holger Waechtler wrote:
> >
> >>Hi,
> >>
> >>I can reproduce this and will try to find the problem today.
> >>
> >>Holger
> >>
> >>
> >>Jeremy Hall wrote:
> >>
> >>>Hello,
> >>>
> >>>I have been experimenting with vdr-1.1.10 and the NEWSTRUCT driver.  As I
> >>>start a FTA channel, go into the menu, and scroll through the channels
> >>>(but don't select one) Soon my vdr freezes.
> >>>
> >>>I am using REMOTE=KBD and DEBUG_OSD=1
> >>>
> >>>The machine has locked up, doesn't respond to pings etc, but the DVB card
> >>>continues to display the FTA channel.
> >>>
> >>>This is with 2.4.19-RC1+LL+PREEMPT+firm timers.  This works out just fine
> >>>with the head driver.  It is configured as a UP kernel.
-- 
_______________________________________________________________

Klaus Schmidinger                       Phone: +49-8635-6989-10
CadSoft Computer GmbH                   Fax:   +49-8635-6989-40
Hofmark 2                               Email:   kls@cadsoft.de
D-84568 Pleiskirchen, Germany           URL:     www.cadsoft.de
_______________________________________________________________