[vdr] Re: navigation in vdr

[Oliver Endriss <o.endriss@gmx.de>]

On Monday 03 February 2003 19:59, Marcel Wiesweg wrote:
> IMO the first improvement would be that the "right" key sets the
> active entry to the bottom if there is only one page (as is the case
> with my main entry which currently contains 12 entries).

Great idea! The following patch implements this feature:
In single-page menues the left/right keys jump to the first/last entry 
of the page. Multi-page menues are not affected.

--- osd.c.old	Sun Dec  8 14:17:13 2002
+++ osd.c	Wed Feb  5 04:48:42 2003
@@ -535,8 +535,6 @@
 
 void cOsdMenu::PageUp(void)
 {
-  if (Count() <= MAXOSDITEMS)
-     return;
   current -= MAXOSDITEMS;
   first -= MAXOSDITEMS;
   if (first < 0)
@@ -551,13 +549,11 @@
 
 void cOsdMenu::PageDown(void) 
 {
-  if (Count() <= MAXOSDITEMS)
-     return;
   current += MAXOSDITEMS;
   first += MAXOSDITEMS;
   if (current > Count() - 1) {
      current = Count() - 1;
-     first = Count() - MAXOSDITEMS;
+     first = max(0, Count() - MAXOSDITEMS);
      }
   if (SpecialItem(current)) {
      current += (current < Count() - 1) ? 1 : -1;

Oliver


-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe vdr" as subject.