[vdr] Re: [PATCH] (DVB-T) statmux fix vbr tagging for pic header

[s.huelswitt@gmx.de (Stefan Huelswitt)]

On 15 May 2003 Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> wrote:

> Recording and Transfer Mode works here both with and without the patch,
> so AFAICS I wouldn't mind adopting this. However, I'm not quite sure
> whether simply poking the three constant byte values into the data stream
> is correct, or whether we should rather set/clear specific bits...

From my limited point of view, I think it would be better to set
only the vbv delay without touching the rest:

 p[i + 5] |= 0x07;
 p[i + 6] |= 0xFF;
 p[i + 7] |= 0xF8;

Messing with bit 7/6 of p[i+5] could change the temporal sequence
number (http://mpucoder.kewlhair.com/DVD/mpeghdrs.html#picture).

Did not tested this patch, so just my two cents.

Regards.

-- 
Stefan Huelswitt
huels@iname.com  | http://home.pages.de/~nathan


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.