[vdr] Re: vdr-1.2.2-libsi.patch

[Oliver Endriss <o.endriss@gmx.de>]

On Monday 11 August 2003 16:42, Klaus Schmidinger wrote:
> Reinhard Nissl wrote:
> > this patch solves a symbol collision of libsi with libxine, which I'm going to
> > use in my plugin.
> >  ...
> Is there a particular reason why crc32() is externally accessible?
> Wouldn't it be enough to remove the declaration crc32() from
> libdtv/libsi/include/libsi.h and make the function 'static' in
> libdtv/libsi/si_parser.c?
> 
> Just an idea... I have no problem applying the above patch, but
> I think a library shouldn't export any functions that aren't
> necessarily needed outside.

Sure, but if you write code which processes raw data, it might be
nice to have such a function. Don't know whether this might be 
useful for plugins...

Oliver


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.