[vdr] Re: Bugreport: Games-Plugin

[Juri Haberland <juri@koschikode.com>]

Ludwig Nussel schrieb:
> Clemens Kirchgatterer wrote:
>> Juri Haberland <juri@koschikode.com> wrote:

>> > There seems to be a fundamental design flaw in either the idea to
>> > include the Make.config in plugins or the template for the Make.config
>> > as distributed with VDR is plain wrong.

>> in the meantime, i would recommend to just comment out the -include
>> within vdr-games/Makefile. maybe somebody with more "make" experience
>> could have a look at it. i'm a little bit short of time 'til the end of
>> the month.
> 
> Move the include before your local modifications of CFLAGS etc.

This would defeat the whole idea of including Make.config in the first
place: To let to user override specific settings via Make.config.

There's a design problem:
Make.config can be used to override some settings, e.g. the location of
the DVB dir. This is done with a perspective from the VDR dir. The
plugins include this file but have a perspective of
VDR/PLUGINS/src/<plugin>/. If a path in Make.config isn't absolute the
plugin will fail.

As nearly all plugins seem to include Make.config the question arises,
why only some plugins fail to compile whereas other compile
successfully. I think this is because those plugins that compile don't
actually use any header files from DVB or those of VDR that reference
DVB header files.

If I comment out the line with DVBDIR in Make.config all plugins
compile. If I change it to an absolute path all plugins compile, too -
besides the new games-plugin - see attached patch for games-0.6.0.

I propose to overcome this problem in the future to comment out the
DVBDIR line in Make.config.template and additionally to change it to an
absolute path. Patch also attached.

Cheers,
Juri
diff -urN games-0.6.0.old/Makefile games-0.6.0/Makefile
--- games-0.6.0.old/Makefile	2003-09-13 11:06:33.000000000 +0200
+++ games-0.6.0/Makefile	2003-09-20 13:32:26.000000000 +0200
@@ -34,13 +34,13 @@
 
 else
 
+-include $(VDRDIR)/Make.config
+
 	TARGET    = libvdr-games.so
 	OBJS     += $(VDROBJS)
 	CFLAGS   += -I$(VDRDIR) -I$(DVBDIR)/include
 	LFLAGS   += -shared --whole-archive
 
--include $(VDRDIR)/Make.config
-
 endif
 
 all:
--- VDR.old/Make.config.template	2003-08-09 13:03:25.000000000 +0200
+++ VDR/Make.config.template	2003-09-20 13:30:20.000000000 +0200
@@ -18,7 +18,7 @@
 
 ### The directory environment:
 
-DVBDIR   = ../DVB
+# DVBDIR   = /usr/src/DVB
 MANDIR   = /usr/local/man
 BINDIR   = /usr/local/bin