[vdr] Re: tiny bug in volume bar (fix)

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Jon Burgess wrote:
> 
> Harf Zatschler wrote:
> 
> > 3) press Vol+, volume bar shows:
> > VOL GBBBBBBBBBBB
> > which it shouldn't (B=blank/transparent)
> 
> Try the patch attached. It works for me with vdr-1.2.5pre2 + dxr3-0.2.1
> 
>         Jon
> 
>   ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> --- menu.c~     2003-09-14 12:42:02.000000000 +0100
> +++ menu.c      2003-09-14 12:49:11.707073096 +0100
> @@ -2868,7 +2868,7 @@
>  :cBitmap(Width, Height, 2)
>  {
>    int l = Prompt ? cBitmap::Width(Prompt) : 0;
> -  int p = (Width - l) * Current / Total;
> +  int p = (Width - l - 1) * Current / Total;
>    Text(0, 0, Prompt, clrGreen);
>    Fill(l, 0, p, Height - 1, clrGreen);
>    Fill(l + p, 0, Width - 1, Height - 1, clrWhite);

I've looked at this over and over again, but I fail to
see why subtracting 1 there would make that big a difference here.

Can you please test whether just changing the line

    Fill(l + p, 0, Width - 1, Height - 1, clrWhite);
to
    Fill(l + p, 0, Width - l - p - 1, Height - 1, clrWhite);

also fixes this?
Don't forget to revert the above change first.

Klaus


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.