[vdr] Re: Nasty bug in StillPicture()

[Oliver Endriss <o.endriss@gmx.de>]

On Saturday 18 October 2003 12:16, Stefan Huelswitt wrote:
> On 17 Oct 2003 Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> wrote:
> 
> Jut a few comments:
> 
> > ...
> >                  // skip header extension
> >                  if ((Data[i + 6] & 0xC0) == 0x80) {
> >                     // MPEG-2 PES header
> >                     offs += 3;
> >    [*]              offs += Data[i + 8];
> >                     len -= 3;
> >                     len -= Data[i + 8];
> >                     }
> >                  else {
> >                     // MPEG-1 PES header
> 
> >                     while (offs < Length && len > 0 && Data[offs] == 0xFF) {
> >                           offs++;
> >                           len--;
> >                           }
> 
> This skips the stuffing bytes. I think mpeg2 can have stuffing
> bytes too, so IMO this should be moved before the mpeg1/mpeg2
> decision (before skip header extension).

No. According to the MPEG-2 reference, stuffing bytes are already
included in the length field of the header extension [*].

Oliver


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.