[vdr] Re: dvbplayer.1.2.6pre-mp2PlayAudio.diff

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Sven Goethel wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Friday 24 October 2003 16:54, Klaus Schmidinger wrote:
> > Sven Goethel wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > ...
> > >
> > >         - recordings (dvbplayer), to use MP2 patch dvbplayer.c:
> > >                 dvbplayer.1.2.6pre-mp2PlayAudio.diff
> > >
> > > @Klaus:
> > >
> > > this patch enables Audio plugin's (PlayAudio/Play),
> > > to receive the MP2 audio, if selected
> > > - - and not to send DD/Ac3 all the time.
> > >
> > > this is good for the new bitstreamout 0.48pre1,
> > > or any other audio plugin cabable of MP2 ..
> > >
> > > so new is (StripAudio):
> > >         - call PlayAudio if MP2 is selected
> > >         - strip AC3 data, if MP2 is selected,
> > >           like MP2 is stripped otherwise
> > >
> > > i hope this patch can make it to 1.2.6 ..
> > > ...
> > >                                            Name:
> > > dvbplayer.1.2.6pre-mp2PlayAudio.diff dvbplayer.1.2.6pre-mp2PlayAudio.diff
> > >    Type: text/x-diff
> > >                                        Encoding: 7bit
> >
> > I guess this has to do with the other patch regarding audio track indexes.
> > Since there will need to be some changes because you have used negative
> > values, and since I want to close version 1.2.6 this weekend (actually
> > today), this can't go in there any more. I'll adopt it in 1.3.0 if you
> > provide an updated patch.
> >
> > Klaus
> 
> not really negative values, 'cause
> in cDvbPlayer::GetAudioTracks the index which is set to -1,
> is only set to -1, if seenDolbyTrack is true. if so - we incr.
> the index about one ;-)
> 
> this minus one / seenDolbyTrack paradigma is only a helper
> to distinguish ac3 from mp2  .

Gee, silly me - I just saw the -1 and got on the wrong track. Sorry.
I was kind of in a hurry because I wanted to get 1.2.6pre3 out today
to have the rest of the weekend available for working on 1.3.0, so
I guess I didn't look close enough...

I'll adopt this for 1.3.

Klaus


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.