[vdr] 1.3.0: Bug in filter.c

[Marcel Wiesweg <marcel.wiesweg@gmx.de>]

Hi,
I found another bug and this time I'm the first to report this I guess ;-)

In filter.c I suggest

bool cFilter::Matches(u_short Pid, u_char Tid)
{
+  if (!on)
+      return false;
  for (cFilterData *fd = data.First(); fd; fd = data.Next(fd)) {
      if (fd->Matches(Pid, Tid))
         return true;
      }
  return false;
}

Apart from being an optimisation, there is a bug when
-a sticky filter data
-requested by more than one filter
-SetStatus(false)
-as it is sticky it is left it in the list
-sectionHandler->Del(fd) has no effect because fh->used remains >0
=> the data is still received

Marcel


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.