[vdr] Re: minor code clean-up / suggestion for more

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

"Prakash K. Cheemplavam" wrote:
> 
> Hi,
> 
> this patch clean a few tidbits (extra ";" and "," and an explicit type
> casting) of vdr and is against vanilla 1.3.13.
> 
> Whiel I am at it. I tried to compile VDR using -pedantic and saw that
> vdr usus a lot of gnu c++ features. Wouldn't it be preferable to try to
> clean up the source to use strict iso c++ conformance? GCC with each
> version gets stricter to iso, so I guess this would be the right
> direction to go.
> 
> What do you think Klaus? If you think it is a good idea, I could start
> working on it, as currently I am a bit bored. ;-)

Well, before starting a monster patch for this, maybe you could point
out what exactly you are referring to.

> Another thing: What about incorporating the new gcc visibility stuff?
> 
> See: http://www.nedprod.com/programs/gccvisibility.html
> 
> Using it (properly) wouldn't break anything but take advantage of newer
> compilers. Gentoo's gcc 3.4.2 already uses the visibility patch and gcc
> 4 will have it by default.

What exactly would be the benefit of this for VDR?

> diff -Nurd vdr-1.3.13.o/sources.h vdr-1.3.13/sources.h
> --- vdr-1.3.13.o/sources.h      2004-01-11 11:35:36.000000000 +0100
> +++ vdr-1.3.13/sources.h        2004-10-23 12:26:01.277157848 +0200
> @@ -21,7 +21,7 @@
>       stTerr  = 0xC000,
>       st_Mask = 0xC000,
>       st_Neg  = 0x0800,
> -    st_Pos  = 0x07FF,
> +    st_Pos  = 0x07FF

This is intentional. That way, if a new one has to be added, no existing
line needs to be touched.

Klaus