Thomas Bergwinkl wrote:
Luca Olivetti wrote:
[...]
react on user-input ('Waiting for Lock' should be done in a thread).cFileWriter is already a thread, and its the only method really needing a lock (isn't it?), so maybe the wait for a lock should be made there,I think 'waiting for lock' is always useful when pids will be set and the device isn't in live-mode. (not only for recordings)
From the announcement: "- No longer explicitly waiting for a tuner lock when switching channels (apparently setting "live" PIDs before the tuner is locked doesn't hurt). Moved the wait into cDevice::AttachReceiver() instead."
but then it'd need to know the device. And then it should check for the dish positioned instead of using a long timeout.What's wrong with a long timeout? When the 'waiting for lock' would be done in a thread, there needn't be a timeout at all. Vdr just would only set pids when there is a lock.
But that may be on the wrong satellite, so it should check that the dish is positioned before waiting for a lock. Anyway it has to be seen if waiting for a lock is really necessary. Bye -- - Yo también quiero una Europa libre de Patentes de Software - - I want a Software Patents Free Europe too! And you? - --------------------------------------------------------------- EuropeSwPatentFree - http://EuropeSwPatentFree.hispalinux.es
Attachment:
signature.asc
Description: OpenPGP digital signature