Re: [V4l2-library] PATCH: libv4l-fix-idct-inline-assembly.diff

Hi,

I was just about to send the same patch :)

Note that this is already incorperated into the libv4l-0.3.2 tarbal release which I'm about to announce.

Regards,

Hans

Gregor Jasny wrote:

Hi,

This patch fixes the input constraint for the sar instruction. It allows only an immediate or cl as shift width.

Thanks, Gregor

Signed-off-by: Gregor Jasny jasny@vidsoft.de

diff -r 61deeffda900 v4l2-apps/lib/libv4l/libv4lconvert/jidctflt.c --- a/v4l2-apps/lib/libv4l/libv4lconvert/jidctflt.c Fri Jul 04 07:21:55 2008 +0200 +++ b/v4l2-apps/lib/libv4l/libv4lconvert/jidctflt.c Fri Jul 04 16:24:33 2008 +0200 @@ -92,7 +92,7 @@ static inline unsigned char descale_and_ "\tcmpl %4,%1\n" "\tcmovg %4,%1\n" : "=r"(x)

•  : "0"(x), "Ir"(shift), "ir"(1UL<<(shift-1)), "r" (0xff), "r" (0)
  

•  : "0"(x), "Ic"((unsigned char)shift), "ir"(1UL<<(shift-1)), "r" (0xff), "r" (0)
   );
  

  return x;

}