Re: [V4l2-library] [PATCH 6/8] V4L: v4l2_extension: aiee, don't deref NULL on fail path in v4l2ext_register - V4L2-library

7 Oct 2007

Jiri Slaby wrote:
...
# HG changeset patch
# User Jiri Slaby jirislaby@gmail.com
# Date 1191677283 -7200
# Node ID f89a5dbbfcf7706106d46d0702659e84db9f33df
# Parent  210b62fbf40aba1dc223da3c47c2db4650dc0ac6
v4l2_extension: aiee, don't deref NULL on fail path in v4l2ext_register
Signed-off-by: Jiri Slaby jirislaby@gmail.com

diff --git a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c
--- a/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c
+++ b/linux/drivers/media/video/v4l2_extension/v4l2_extension-video.c
@@ -657,11 +657,12 @@ int v4l2ext_register(struct video_device
   /* Error case, cleanup what must be cleaned */
  out_free:
   v4l2ext_devused &= ~(1 << nr);

if (dev)


if (dev) {
video_device_release(dev->vdev);
kfree(dev->fake_file.f_dentry);


}
kfree(fake_inode);
kfree(dev);


kfree(fake_inode);
kfree(dev->fake_file.f_dentry);

out:
   return ret;
 }
Patch committed at http://linuxtv.org/hg/~tmerle/v4l2_extension/
Thierry

    