Am Samstag, den 06.02.2010, 12:29 +0100 schrieb Klaus Schmidinger:
On 29.01.2010 15:19, Paul Menzel wrote:
Without this patch, if some options in `Makefile` were set outside `Makefile` and no `Make.config` existed with the necessary options, builds could fail. [1][2][3]
Therefore include strictly necessary options in `Make.global` and include this in all the Makefiles before `Make.config`.
[1] http://www.linuxtv.org/pipermail/vdr/2009-July/020977.html [2] http://www.linuxtv.org/pipermail/vdr/2009-December/021807.html [3] http://www.linuxtv.org/pipermail/vdr/2010-January/022235.html
v2: Use `include` instead of `-include` to get a warning/error if it is not present. [4] v3: Change according to Frank’s comments [5]. • Delete options set in `Make.global` from other Makefiles. • Leave adding `-fPIC` to `C[XX]FLAGS` in `Make.config.template` as the flags get reset including `Make.config`. • Modify `newplugin`.
[4] http://www.gnu.org/software/make/manual/make.html#Include [5] http://www.linuxtv.org/pipermail/vdr/2010-January/022243.html
Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net ...
Is it safe to assume that this is the final version everybody has agreed upon?
I think so, since nobody commented on this anymore, it can be applied. Frank told me I should submit it to you. Great that you were faster.
I do not know when you will release the 1.7.13. If it is still some days away then maybe we can set a limit of seven days to give everyone a chance again to comment on this patch and you can apply it afterward.
Thanks,
Paul