I would love to see this implemented and I would gladly write the patch if I had the programming skills.
Can any kind person write this patch? I am guessing it is probably no more than 12 lines of code??
Begin forwarded message:
Date: Sun, 13 Jun 2010 13:03:49 +0200 From: Klaus Schmidinger Klaus.Schmidinger@tvdr.de Subject: Re: [vdr] Feature request: program guide scroll To: vdr@linuxtv.org Message-ID: 4C14BB15.7060605@tvdr.de Content-Type: text/plain; charset=iso-8859-1
On 06/07/10 11:55, Istv?n F?ley wrote:
Klaus Schmidinger wrote:
"Left" and "Right" are used to page up/down within long list, and that's not going to change. However, we could use the Green and Yellow buttons (and additionally the kPrev and kNext keys) for this.
Klaus
Klaus, is this an abandoned feature, or it just has a lower priority?
Well, it has *no* priority to *me* ;-) So if you want this, you can suggest a patch.
Klaus
Am 17.06.2010 17:31, schrieb martinez:
Date: Sun, 13 Jun 2010 13:03:49 +0200 From: Klaus Schmidinger Klaus.Schmidinger@tvdr.de Subject: Re: [vdr] Feature request: program guide scroll
Well, it has *no* priority to *me* ;-) So if you want this, you can suggest a patch.
I would love to see this implemented and I would gladly write the patch if I had the programming skills.
Can any kind person write this patch?
I'll see if I can come up with something on the weekend.
@Klaus: For this the cMenuEvent needs to know about the sequence of events instead of just one event. Would it be ok for you to pass a pointer to the parent cOsdMenu to cMenuEvent, in order to get all the cMenuScheduleItem menu items (and their event) from it? This would probably be in an alternate constructor. Otherwise a second list of all matching events has to be created, to pass it on.
Cheers,
Udo
Am 17.06.2010 19:29, schrieb Udo Richter:
Am 17.06.2010 17:31, schrieb martinez:
Can any kind person write this patch?
I'll see if I can come up with something on the weekend.
As always, the more close you look on it, the more complicated it gets. In other words, it got a little more than 12 lines... ;)
The cMenuEvent can now switch through the list of events of the parent menu with the green and yellow buttons. Depending on the parent menu, the buttons either show channel names or event starting times. From timer menu (blue button), the green and yellow buttons stay empty.
To gain access to the list of events, I've added an abstract cEventSequence class that is implemented by cMenuWhatsOn and cMenuSchedule. That way these two and the cMenuScheduleItem can continue to be private to menu.c.
Since now the cMenuEvent can handle different events, a convenient shortcut had to be removed: Previously, the red and blue buttons were handled by the parent menu, not cMenuEvent itself. cMenuEvent now does this on its own. Also the constructor parameters CanSwitch and Buttons were dropped and replaced by dynamic code. By this change, the event info on blue key in timers menu gains the red and blue button for free.
cMenuEvent had its ProcessKey re-arranged, as the original version could not handle sub-menus. (the parent menu did.)
Timer menu got a bug fix to handle sub-sub-menus without overwriting the button bar.
The attached patch is against vdr-1.6, but also cleanly applies and compiles on vdr-1.7.15.
A little testing help and feedback is welcome. Check that the green and yellow buttons work in program, whats now, whats next and timer info menu, and keep an eye on button bar text in the event menu and the parent menu after exiting. Also, the t and T markers on events should change, and in the timer menu the '>' for active timers, if you change that. Try adding timers from the event menu for running and future events. Try whether the blue key switches to the right channel. And try whatever else you can imagine.
Cheers,
Udo
On 20 June 2010 01:37, Udo Richter udo_richter@gmx.de wrote:
Am 17.06.2010 19:29, schrieb Udo Richter:
Am 17.06.2010 17:31, schrieb martinez:
Can any kind person write this patch?
I'll see if I can come up with something on the weekend.
While you're at it, what about a configurable option to have the right and left keys change volume instead of scrolling up and down? A lot of remotes have the volume on those keys. It could be disable by default while the menu is displayed of course.
On Sat, Jun 19, 2010 at 3:54 PM, Torgeir Veimo torgeir@netenviron.com wrote:
While you're at it, what about a configurable option to have the right and left keys change volume instead of scrolling up and down? A lot of remotes have the volume on those keys. It could be disable by default while the menu is displayed of course.
There's tons of remotes with different configurations. Some use arrow keys up/down, some use left/right, some use dedicated volume buttons. You should probably look into editing your remote.conf to properly reflect the buttons on your remote I guess.
On Sat, 19 Jun 2010 15:58:52 -0700 VDR User user.vdr@gmail.com wrote:
On Sat, Jun 19, 2010 at 3:54 PM, Torgeir Veimo torgeir@netenviron.com wrote:
While you're at it, what about a configurable option to have the right and left keys change volume instead of scrolling up and down? A lot of remotes have the volume on those keys. It could be disable by default while the menu is displayed of course.
There's tons of remotes with different configurations. Some use arrow keys up/down, some use left/right, some use dedicated volume buttons. You should probably look into editing your remote.conf to properly reflect the buttons on your remote I guess.
But can VDR work correctly if the volume keys are also left & right? Ie can it use them as a volume control while playing something but use the same keys for navigation in menus etc?
On Sat, Jun 19, 2010 at 5:20 PM, Tony Houghton h@realh.co.uk wrote:
There's tons of remotes with different configurations. Some use arrow keys up/down, some use left/right, some use dedicated volume buttons. You should probably look into editing your remote.conf to properly reflect the buttons on your remote I guess.
But can VDR work correctly if the volume keys are also left & right? Ie can it use them as a volume control while playing something but use the same keys for navigation in menus etc?
Only takes a few seconds to give it a try! ;)
On 20 June 2010 09:24, VDR User user.vdr@gmail.com wrote:
On Sat, Jun 19, 2010 at 5:20 PM, Tony Houghton h@realh.co.uk wrote:
There's tons of remotes with different configurations. Some use arrow keys up/down, some use left/right, some use dedicated volume buttons. You should probably look into editing your remote.conf to properly reflect the buttons on your remote I guess.
But can VDR work correctly if the volume keys are also left & right? Ie can it use them as a volume control while playing something but use the same keys for navigation in menus etc?
Only takes a few seconds to give it a try! ;)
My volume up/down keys doesn't change options in any option menu, it only changes the volume. The idea was to have them work as left right while the menu is active.
Am 20.06.2010 00:54, schrieb Torgeir Veimo:
On 20 June 2010 01:37, Udo Richter udo_richter@gmx.de wrote:
Am 17.06.2010 19:29, schrieb Udo Richter:
Am 17.06.2010 17:31, schrieb martinez:
Can any kind person write this patch?
I'll see if I can come up with something on the weekend.
While you're at it, what about a configurable option to have the right and left keys change volume instead of scrolling up and down? A lot of remotes have the volume on those keys. It could be disable by default while the menu is displayed of course.
What exactly does the EPG event display have to do with the meaning of left/right key in live TV view?
Also, the left/right key in live TV view is already in use.
Cheers,
Udo
On Sun, 20 Jun 2010 08:54:23 +1000, Torgeir Veimo wrote
While you're at it, what about a configurable option to have the right and left keys change volume instead of scrolling up and down? A lot of remotes have the volume on those keys. It could be disable by default while the menu is displayed of course.
I wrote such a patch quite a while ago for VDR 1.4. Just ported it to VDR-1.7.12. Please see README for an explanation of the options. Patch is available from http://vdr.schmirler.de/volctrl/
Regards, Frank
I'd tried your patch last night, but unfortunamtely ... I haven't seen any changes. My vdr 1.7.10 is patched with liemikuutio patch, and your patch applied with some 20 line offsets, but it said, that all the hunks succeded. I will try with a plain vdr this evening.
István
Udo Richter wrote:
Am 17.06.2010 19:29, schrieb Udo Richter:
Am 17.06.2010 17:31, schrieb martinez:
Can any kind person write this patch?
I'll see if I can come up with something on the weekend.
As always, the more close you look on it, the more complicated it gets. In other words, it got a little more than 12 lines... ;)
The cMenuEvent can now switch through the list of events of the parent menu with the green and yellow buttons. Depending on the parent menu, the buttons either show channel names or event starting times. From timer menu (blue button), the green and yellow buttons stay empty.
To gain access to the list of events, I've added an abstract cEventSequence class that is implemented by cMenuWhatsOn and cMenuSchedule. That way these two and the cMenuScheduleItem can continue to be private to menu.c.
Since now the cMenuEvent can handle different events, a convenient shortcut had to be removed: Previously, the red and blue buttons were handled by the parent menu, not cMenuEvent itself. cMenuEvent now does this on its own. Also the constructor parameters CanSwitch and Buttons were dropped and replaced by dynamic code. By this change, the event info on blue key in timers menu gains the red and blue button for free.
cMenuEvent had its ProcessKey re-arranged, as the original version could not handle sub-menus. (the parent menu did.)
Timer menu got a bug fix to handle sub-sub-menus without overwriting the button bar.
The attached patch is against vdr-1.6, but also cleanly applies and compiles on vdr-1.7.15.
A little testing help and feedback is welcome. Check that the green and yellow buttons work in program, whats now, whats next and timer info menu, and keep an eye on button bar text in the event menu and the parent menu after exiting. Also, the t and T markers on events should change, and in the timer menu the '>' for active timers, if you change that. Try adding timers from the event menu for running and future events. Try whether the blue key switches to the right channel. And try whatever else you can imagine.
Cheers,
Udo
vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
-
Frank Schmirler -
István Füley -
martinez -
Tony Houghton -
Torgeir Veimo -
Udo Richter -
VDR User