Hi Klaus,
I just installed vdr-1.5.3, but lcdproc plugin caused vdr to crash on startup. I figured out that the problem is the translation of the string "Volume ". Unlike the other strings that are used by the plugin this string is provided by the vdr-core i18n.c This worked fine in vdr-1.5.1. Adding a dummy translation of "Volume " directly in the plugins i18n.c "fixed" the crash. Is this the intended behaviour? Or was this a feature by accident? ;-)
Regards, Joachim.
On 06/10/07 21:43, Joachim Wilke wrote:
Hi Klaus,
I just installed vdr-1.5.3, but lcdproc plugin caused vdr to crash on startup. I figured out that the problem is the translation of the string "Volume ". Unlike the other strings that are used by the plugin this string is provided by the vdr-core i18n.c This worked fine in vdr-1.5.1. Adding a dummy translation of "Volume " directly in the plugins i18n.c "fixed" the crash. Is this the intended behaviour? Or was this a feature by accident? ;-)
This was certainly unintended. I'll look into it.
Klaus
Hi All, hi Klaus,
here is a patch for this problem:
--- /home/riedel/GENS/orig-vdr/vdr-1.5.3.orig/i18n.c 2007-06-09 10:44:54.000000000 +0200 +++ /home/riedel/GENS/orig-vdr/vdr-1.5.3/i18n.c 2007-06-11 23:40:43.000000000 +0200 @@ -6820,7 +6820,7 @@ *Converted = new tI18nPhrase[NumPhrases + 1]; memset(*Converted, 0, sizeof(tI18nPhrase) * (NumPhrases + 1)); } - if (!(*Converted)[NrPhrase][NrLanguage]) { + if (!(*Converted)[NrPhrase][NrLanguage] && Original[NrPhrase][NrLanguage] ) { cCharSetConv csc(Phrases[1][NrLanguage], cCharSetConv::SystemCharacterTable()); (*Converted)[NrPhrase][NrLanguage] = strdup(csc.Convert(Original[NrPhrase][NrLanguage])); }
Now work it for other Languages, for example with OSDLanguage = 16
Klaus Schmidinger wrote:
On 06/10/07 21:43, Joachim Wilke wrote:
Hi Klaus,
I just installed vdr-1.5.3, but lcdproc plugin caused vdr to crash on startup. I figured out that the problem is the translation of the string "Volume ". Unlike the other strings that are used by the plugin this string is provided by the vdr-core i18n.c This worked fine in vdr-1.5.1. Adding a dummy translation of "Volume " directly in the plugins i18n.c "fixed" the crash. Is this the intended behaviour? Or was this a feature by accident? ;-)
This was certainly unintended. I'll look into it.
Klaus
vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Hi,
I still had crashes even when using Alexanders patch. I think the fix should look like this (diff against plain 1.5.3):
--- vdr-1.5.3/i18n.c 2007-06-09 10:44:54.000000000 +0200 +++ vdr-1.5.3-patched/i18n.c 2007-06-12 19:40:42.000000000 +0200 @@ -6851,7 +6851,7 @@ return t; } } - p = Phrases; + p = OriginalPhrases = Phrases; } esyslog("%s%sno translation found for '%s' in language %d (%s)", Plugin ? Plugin : "", Plugin ? ": " : "", s, Setup.OSDLanguage, Phrases[0][Setup.OSDLanguage]); }
BR,
Christian
2007/6/12, Christian Wieninger cwieninger@gmx.de:
I still had crashes even when using Alexanders patch. I think the fix should look like this (diff against plain 1.5.3):
Hi,
I'm sorry but neither the first nor the second patch do work here. I still get an segfault when lcdproc tries to translate "Volume ".
Regards, Joachim.
Hi, please try both patches together. I have also problems after ma first patch with softdevice translations, but now with Christian's patch is OK.
-----Original Message----- Date: Tue, 12 Jun 2007 20:35:29 +0200 Subject: Re: [vdr] vdr-1.5.3 - issue with translations out of plugins From: "Joachim Wilke" To: "VDR Mailing List"
2007/6/12, Christian Wieninger :
I still had crashes even when using Alexanders patch. I think the fix should look like this (diff against plain 1.5.3):
Hi,
I'm sorry but neither the first nor the second patch do work here. I still get an segfault when lcdproc tries to translate "Volume ".
Regards, Joachim.
_______________________________________________ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
On 06/12/07 22:54, alexander-riedel@t-online.de wrote:
Hi, please try both patches together. I have also problems after ma first patch with softdevice translations, but now with Christian's patch is OK.
I haven't had much time to look into this, yet, but I believe the attached patch should be all it takes to fix this.
Can you please try this one?
Klaus
unfortunately this patches do not fix Transtation problems complete. i still have segmentation faults for example with softdevice plugin. maybe this help: vdr has translation "none". softdevice as also "none"..... at this translation "none" have i core dumps...
Klaus what about gettext? This ist better alternative to "Home-made" converting.
Or minimaly without on the fly converting of i18n strings, these string use from the begin as utf8 strings.
??
-----Original Message----- Date: Tue, 12 Jun 2007 23:41:37 +0200 Subject: Re: [vdr] vdr-1.5.3 - issue with translations out of plugins From: Klaus Schmidinger Klaus.Schmidinger@cadsoft.de To: vdr@linuxtv.org
On 06/12/07 22:54, alexander-riedel@t-online.de wrote:
Hi, please try both patches together. I have also problems after ma first patch with softdevice
translations,
but now with Christian's patch is OK.
I haven't had much time to look into this, yet, but I believe the attached patch should be all it takes to fix this.
Can you please try this one?
Klaus
On 06/13/07 00:21, alexander-riedel@t-online.de wrote:
unfortunately this patches do not fix Transtation problems complete. i still have segmentation faults for example with softdevice plugin. maybe this help: vdr has translation "none". softdevice as also "none"..... at this translation "none" have i core dumps...
Well, it was just a quick shot. I'll look into it over the weekened.
Klaus what about gettext? This ist better alternative to "Home-made" converting.
In the long run this is the plan, but as a first step I wanted to do the freetype and UTF-8 stuff separately.
Or minimaly without on the fly converting of i18n strings, these string use from the begin as utf8 strings.
At least the German texts need to remain iso8859-1, because I maintain these myself ;-)
Klaus
Hi Klaus,
Klaus Schmidinger wrote:
On 06/13/07 00:21, alexander-riedel@t-online.de wrote:
unfortunately this patches do not fix Transtation problems complete. i still have segmentation faults for example with softdevice plugin. maybe this help: vdr has translation "none". softdevice as also "none"..... at this translation "none" have i core dumps...
Well, it was just a quick shot. I'll look into it over the weekened.
Klaus what about gettext? This ist better alternative to "Home-made" converting.
In the long run this is the plan, but as a first step I wanted to do the freetype and UTF-8 stuff separately.
Or minimaly without on the fly converting of i18n strings, these string use from the begin as utf8 strings.
If you remeber the thread almost 2 years ago, "OSD language settings stored as language code (was: i18n.c sorted)" http://linvdr.org/mailinglists/vdr/2005/11/msg00646.html at that time you first found it a good idea, then postponed it for 1.5.x. Right after that I also developed a working gettext patch based on this one, and of course, Alexander Riedel's UTF8-patch as it looked like at that time. Now you integrated utf8/freetype in vanilla VDR yourself, and from what I've read (haven't tried or looked at the code yet) it seems you used at least parts of that UTF8 ideas. What plans do you have about gettext, how long would that run be? Would it make sense if I'd rework my gettext patch based on the current VDR developer version in the near future (I developed it exactly having in mind your sketched ideas fom that time
"There would be one file for each language in VDR itself, and each plugin would also have its own set of language files. There will also be a way of converting the exiting i18n files into the new format." ). Interested (in the next weeks, not right now...)?
Lucian
On 06/29/07 07:21, Lucian Muresan wrote:
Hi Klaus,
Klaus Schmidinger wrote:
On 06/13/07 00:21, alexander-riedel@t-online.de wrote:
unfortunately this patches do not fix Transtation problems complete. i still have segmentation faults for example with softdevice plugin. maybe this help: vdr has translation "none". softdevice as also "none"..... at this translation "none" have i core dumps...
Well, it was just a quick shot. I'll look into it over the weekened.
Klaus what about gettext? This ist better alternative to "Home-made" converting.
In the long run this is the plan, but as a first step I wanted to do the freetype and UTF-8 stuff separately.
Or minimaly without on the fly converting of i18n strings, these string use from the begin as utf8 strings.
If you remeber the thread almost 2 years ago, "OSD language settings stored as language code (was: i18n.c sorted)" http://linvdr.org/mailinglists/vdr/2005/11/msg00646.html at that time you first found it a good idea, then postponed it for 1.5.x. Right after that I also developed a working gettext patch based on this one, and of course, Alexander Riedel's UTF8-patch as it looked like at that time. Now you integrated utf8/freetype in vanilla VDR yourself, and from what I've read (haven't tried or looked at the code yet) it seems you used at least parts of that UTF8 ideas. What plans do you have about gettext, how long would that run be? Would it make sense if I'd rework my gettext patch based on the current VDR developer version in the near future (I developed it exactly having in mind your sketched ideas fom that time
I'm currently on vacation and won't be home until July 14.
I thought I had a gettext patch in my inbox, but apparently I can't find it. Have you sent that to me before?
Just send me your patch as it is (doesn't necessarily need to work with version 1.5.5 directly) and I'll take a look at it.
Klaus
2007/6/12, Klaus Schmidinger Klaus.Schmidinger@cadsoft.de:
I haven't had much time to look into this, yet, but I believe the attached patch should be all it takes to fix this.
It works here!
Regards, Joachim.
Hi everbody,
I also tried both patches together and this did also not fix the problem with the translation of "Volume " out of lcdproc-Plugin.
Regards, Matthias
2007/6/12, alexander-riedel@t-online.de alexander-riedel@t-online.de:
Hi, please try both patches together. I have also problems after ma first patch with softdevice translations, but now with Christian's patch is OK.
-----Original Message----- Date: Tue, 12 Jun 2007 20:35:29 +0200 Subject: Re: [vdr] vdr-1.5.3 - issue with translations out of plugins From: "Joachim Wilke" To: "VDR Mailing List"
2007/6/12, Christian Wieninger :
I still had crashes even when using Alexanders patch. I think the fix should look like this (diff against plain 1.5.3):
Hi,
I'm sorry but neither the first nor the second patch do work here. I still get an segfault when lcdproc tries to translate "Volume ".
Regards, Joachim.
vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
On 06/13/07 12:50, Matthias Becker wrote:
Hi everbody,
I also tried both patches together and this did also not fix the problem with the translation of "Volume " out of lcdproc-Plugin.
Please try the attached patch (against plain VDR 1.5.3). There was still a problem in cCharSetConv::Convert() in case an empty string was given.
Klaus
-
Alexander Riedel -
alexander-riedel＠t-online.de
-
Christian Wieninger -
Joachim Wilke -
Klaus Schmidinger -
Lucian Muresan -
Matthias Becker -
Oleg Roitburd