When using vdr-1.3.25, I cant seem to find the code in text2skin to display the recording summary properly. The summary just comes up blank. When I do not use text2skin, then it works just fine. The conversion of summary.vdr to info.vdr went fine. Can anyone give me a hint?
Best Regards,
C.Y.M wrote:
When using vdr-1.3.25, I cant seem to find the code in text2skin to display the recording summary properly. The summary just comes up blank. When I do not use text2skin, then it works just fine. The conversion of summary.vdr to info.vdr went fine. Can anyone give me a hint?
Skin plugins require a patch. From 1.3.25 changelog:
- The "Summary" button in the "Recordings" menu has been renamed to "Info", and the page it brings up now shows the recording's information, much like the EPG event page. Therefore it now no longer uses the skin's SetText() function, but rather the SetRecording() function. Skin plugins may need to adjust that function accordingly (see skinsttng.c, for instance).
C.Y.M wrote:
When using vdr-1.3.25, I cant seem to find the code in text2skin to display the recording summary properly. The summary just comes up blank. When I do not use text2skin, then it works just fine. The conversion of summary.vdr to info.vdr went fine. Can anyone give me a hint?
From the announcement (emphasis mine):
The "Summary" button in the "Recordings" menu has been renamed to "Info", and the page it brings up now shows the recording's information, much like the EPG event page. Therefore it now no longer uses the skin's SetText() function, but rather the SetRecording() function. ****Skin plugins may need to adjust that function accordingly (see skinsttng.c, for instance)****.
Bye
Anssi Hannula wrote:
C.Y.M wrote:
When using vdr-1.3.25, I cant seem to find the code in text2skin to display the recording summary properly. The summary just comes up blank. When I do not use text2skin, then it works just fine. The conversion of summary.vdr to info.vdr went fine. Can anyone give me a hint?
Skin plugins require a patch. From 1.3.25 changelog:
- The "Summary" button in the "Recordings" menu has been renamed to
"Info", and the page it brings up now shows the recording's information, much like the EPG event page. Therefore it now no longer uses the skin's SetText() function, but rather the SetRecording() function. Skin plugins may need to adjust that function accordingly (see skinsttng.c, for instance).
I saw the changelog, but I was not sure how do go about it. The change in skinssttng.c was about 32 additional lines. Does someone already have a patch for text2skin? I guess I need to look at display.[ch] some more.
Regards,
C.Y.M wrote:
Anssi Hannula wrote:
C.Y.M wrote:
When using vdr-1.3.25, I cant seem to find the code in text2skin to display the recording summary properly. The summary just comes up blank. When I do not use text2skin, then it works just fine. The conversion of summary.vdr to info.vdr went fine. Can anyone give me a hint?
Skin plugins require a patch. From 1.3.25 changelog:
- The "Summary" button in the "Recordings" menu has been renamed to
"Info", and the page it brings up now shows the recording's information, much like the EPG event page. Therefore it now no longer uses the skin's SetText() function, but rather the SetRecording() function. Skin plugins may need to adjust that function accordingly (see skinsttng.c, for instance).
I saw the changelog, but I was not sure how do go about it. The change in skinssttng.c was about 32 additional lines. Does someone already have a patch for text2skin? I guess I need to look at display.[ch] some more.
I *think* I have an small understanding now of why the summary of recordings are not displayed. In particular, I'm referring to the Enigma skin with text2skin 1.0.
If we examine the Enigma.skin file, notice the following line:
--SNIP--
<scrolltext condition="not(equal({MenuTitle:clean},trans('Summary')))" x1="10" x2="-106" y1="35" y2="-36" font="VeraMono.ttf:22,85" color="MenuTxtFG">{MenuText}</scrolltext>
--SNIP--
This means that "MenuText" is the function called when selecting the summary of a recording.
After some more digging, display.c shows that mText is returned when calling MenuText from the following code:
--SNIP--
case tMenuText: return mText;
--SNIP--
Next we look for the origin of mText which is supplied by the following function:
--SNIP--
void cText2SkinDisplayMenu::SetText(const char *Text, bool FixedFont) { if (mFallbackDisplay != NULL) { mFallbackDisplay->SetText(Text, FixedFont); return; }
UpdateLock(); if (Text == NULL) Text = ""; if (mText != Text) { mText = Text; SetDirty(); } UpdateUnlock(); }
--SNIP--
Ok, so what to do next? Well, my guess would be to change the following line:
case tMenuText: return mRecording;
This in turn would reference "cText2SkinDisplayMenu::SetRecording" instead of "cText2SkinDisplayMenu::SetText".
Am I getting close? I am no expert at this and any help would be greatly appreciated..
Best Regards,
C.Y.M wrote:
C.Y.M wrote:
Anssi Hannula wrote:
C.Y.M wrote:
When using vdr-1.3.25, I cant seem to find the code in text2skin to display the recording summary properly. The summary just comes up blank. When I do not use text2skin, then it works just fine. The conversion of summary.vdr to info.vdr went fine. Can anyone give me a hint?
Skin plugins require a patch. From 1.3.25 changelog:
- The "Summary" button in the "Recordings" menu has been renamed to
"Info", and the page it brings up now shows the recording's information, much like the EPG event page. Therefore it now no longer uses the skin's SetText() function, but rather the SetRecording() function. Skin plugins may need to adjust that function accordingly (see skinsttng.c, for instance).
I saw the changelog, but I was not sure how do go about it. The change in skinssttng.c was about 32 additional lines. Does someone already have a patch for text2skin? I guess I need to look at display.[ch] some more.
I *think* I have an small understanding now of why the summary of recordings are not displayed. In particular, I'm referring to the Enigma skin with text2skin 1.0.
It appears that text2skin now has support for vdr-1.3.25 in cvs. Thanks!
2005-06-xx: Version 1.1
- fixed a race condition (thanks to Reinhard Nissl for pointing this out) - updated finnish translations (thanks to Rolf Ahrenberg) - added tokens for Recording Info Display (RecordingName, RecordingDateTime, RecordingTitle, RecordingShortText, RecordingDescription, RecordingLanguageCode, RecordingLanguageDescription)
My question now is, what do I need to change in the .skin file? I am assuming that now all the .skin files must be fixed to support the new tokens.
Best Regards,
I *think* I have an small understanding now of why the summary of recordings are not displayed. In particular, I'm referring to the Enigma skin with text2skin 1.0.
It appears that text2skin now has support for vdr-1.3.25 in cvs. Thanks!
2005-06-xx: Version 1.1
- fixed a race condition (thanks to Reinhard Nissl for pointing this out)
- updated finnish translations (thanks to Rolf Ahrenberg)
- added tokens for Recording Info Display (RecordingName, RecordingDateTime, RecordingTitle, RecordingShortText, RecordingDescription, RecordingLanguageCode, RecordingLanguageDescription)
My question now is, what do I need to change in the .skin file? I am assuming that now all the .skin files must be fixed to support the new tokens.
Best Regards,
Attached is a patch for the Enigma.skin that fixes the Info display for recordings.
Best Regards,
--- Enigma.skin.pre25 2005-05-30 02:03:50.000000000 -0700 +++ Enigma.skin 2005-05-30 14:15:25.000000000 -0700 @@ -661,13 +661,13 @@ </block> <!-- Menu-text --> - <block condition="{MenuText}"> + <block condition="{RecordingDescription}"> <!-- background --> <rectangle x1="0" x2="-95" y1="30" y2="93" color="MenuAltBG"/> <rectangle x1="0" x2="-1" y1="94" y2="-31" color="MenuAltBG"/> - <scrolltext condition="equal({MenuTitle:clean},trans('Summary'))" x1="10" x2="-106" y1="35" y2="-36" font="Vera.ttf:22,85" color="MenuTxtFG">{MenuText}</scrolltext> - <scrolltext condition="not(equal({MenuTitle:clean},trans('Summary')))" x1="10" x2="-106" y1="35" y2="-36" font="VeraMono.ttf:22,85" color="MenuTxtFG">{MenuText}</scrolltext> + <scrolltext condition="equal({MenuTitle:clean},trans('Summary'))" x1="10" x2="-106" y1="35" y2="-36" font="Vera.ttf:22,85" color="MenuTxtFG">{RecordingDescription}</scrolltext> + <scrolltext condition="not(equal({MenuTitle:clean},trans('Summary')))" x1="10" x2="-106" y1="35" y2="-36" font="VeraMono.ttf:22,85" color="MenuTxtFG">{RecordingDescription}</scrolltext> </block> <!-- Show recordings (in all menus except 'Extended EPG-info' and 'MenuText') -->
I have used VDR for a 18 months now, but in the last 2 months found that stability has gone completely out of the window. It started when I tried to get the vdrsync code working to burn dvd's (never successful).
I have a Pentium P4, 2.4Ghz, 512 MB Ram, 2 x 120 GB IDE disks, with an ASUS motherboard. Cards are a TT-FF DVB-T and a Nebula DVB budget card. I had so many problems I reverted to rebuilding the system from scratch. I was working on linux 2.6.4, but listening to the list I upgraded to 2.6.11 on the rebuild.
Things have not got better.
It is impossible to record anything from the budget card, which is VDR's preferred card. I get so many errors trying to sync to skip bytes to sync to a TS packet it is untrue. The recording makes old VCR's look good. Funny this, because the DVBT enabled television is just fine.
I tried recording just of the TT-FF card. OK, I can only record one signal at a time, but at least it will be stable, right? Wrong. It's as unstable as an unpatched windows box.
For example:
May 30 22:50:22 vdr vdr[8931]: timer 1 (1 2240-0045 'Total Recall') set to event Mon 30.05.2005 22:50-00:35 'Total Recall' May 30 22:54:11 vdr vdr[8935]: channel 1 (BBC ONE) event 22:50 'Total Recall' status 4 May 30 23:03:38 vdr vdr[8935]: channel 3 (BBC THREE) event 23:00 'Ideal' status 4 May 30 23:07:45 vdr vdr[8991]: ERROR: unknown picture type '5' May 30 23:07:46 vdr vdr[8991]: ERROR: unknown picture type '4' May 30 23:11:01 vdr vdr[8931]: connect from 127.0.0.1, port 47508 - accepted May 30 23:11:01 vdr vdr[8931]: closing SVDRP connection May 30 23:16:50 vdr vdr[8991]: ERROR: unknown picture type '5' May 30 23:18:30 vdr last message repeated 5 times May 30 23:18:51 vdr last message repeated 2 times May 30 23:21:02 vdr vdr[8931]: connect from 127.0.0.1, port 43811 - accepted May 30 23:21:02 vdr vdr[8931]: closing SVDRP connection May 30 23:25:15 vdr vdr[8991]: ERROR: unknown picture type '5' May 30 23:25:15 vdr vdr[8991]: initiating emergency exit May 30 23:25:15 vdr vdr[8991]: ERROR: unknown picture type '4' May 30 23:25:15 vdr vdr[8991]: initiating emergency exit May 30 23:25:15 vdr vdr[8991]: ERROR: unknown picture type '5' May 30 23:25:15 vdr vdr[8991]: initiating emergency exit May 30 23:25:16 vdr vdr[8931]: emergency exit requested - shutting down May 30 23:25:16 vdr vdr[8931]: timer 1 (1 2240-0045 'Total Recall') stop May 30 23:25:16 vdr vdr[8931]: saved setup to /root/vdr/setup.conf May 30 23:25:16 vdr vdr[8931]: exiting May 30 23:25:16 vdr vdr[8931]: emergency exit!
My recording stops in the middle with an unknown picture type. At this point, nothing I do other than reboot will restore VDRAdmin (probably the most important feature of VDR IMHO).
I have tried VDR 1.3.25, I have reverted to 1.3.20. I have taken the latest versions of firmware, I have reverted to those that came with the card.
Am I alone in thinking that, for anyone who wants to actually watch TV, the answer is a SKY+ box. Please, god forbid it should come to that.
What am I doing wrong here?
HELP !
Adrian P Challinor
If you want to start a new discussion, please do not use reply. Start a new message.
Otherwise its a contribution to the previous thread (here: Summary missing when using Text2skin), which is obviously not your intend.
Kind regards, Stefan
C.Y.M wrote:
Attached is a patch for the Enigma.skin that fixes the Info display for recordings.
The previous patch introduced a bug that prevented output from being displayed in the "Commands" Menu. Here is a proper patch.
Best Regards,
--- Enigma/Enigma.skin.pre25 2005-05-30 02:03:50.000000000 -0700 +++ Enigma/Enigma.skin 2005-05-31 02:30:20.000000000 -0700 @@ -669,6 +669,15 @@ <scrolltext condition="equal({MenuTitle:clean},trans('Summary'))" x1="10" x2="-106" y1="35" y2="-36" font="Vera.ttf:22,85" color="MenuTxtFG">{MenuText}</scrolltext> <scrolltext condition="not(equal({MenuTitle:clean},trans('Summary')))" x1="10" x2="-106" y1="35" y2="-36" font="VeraMono.ttf:22,85" color="MenuTxtFG">{MenuText}</scrolltext> </block> + + <block condition="{RecordingDescription}"> + <!-- background --> + <rectangle x1="0" x2="-95" y1="30" y2="93" color="MenuAltBG"/> + <rectangle x1="0" x2="-1" y1="94" y2="-31" color="MenuAltBG"/> + + <scrolltext condition="equal({MenuTitle:clean},trans('Summary'))" x1="10" x2="-106" y1="35" y2="-36" font="Vera.ttf:22,85" color="MenuTxtFG">{RecordingDescription}</scrolltext> + <scrolltext condition="not(equal({MenuTitle:clean},trans('Summary')))" x1="10" x2="-106" y1="35" y2="-36" font="VeraMono.ttf:22,85" color="MenuTxtFG">{RecordingDescription}</scrolltext> + </block> <!-- Show recordings (in all menus except 'Extended EPG-info' and 'MenuText') --> <block condition="and(not({PresentTitle}),not({MenuText}),{CurrentRecording})">
C.Y.M wrote:
C.Y.M wrote:
Attached is a patch for the Enigma.skin that fixes the Info display for recordings.
The previous patch introduced a bug that prevented output from being displayed in the "Commands" Menu. Here is a proper patch.
I found another bug in the previous patches, which prevented the skin from displaying the proper requested font. Attached is a fixed version.
Regards.
--- Enigma/Enigma.skin.pre25 2005-05-30 02:03:50.000000000 -0700 +++ Enigma/Enigma.skin 2005-05-31 02:48:00.000000000 -0700 @@ -669,6 +669,15 @@ <scrolltext condition="equal({MenuTitle:clean},trans('Summary'))" x1="10" x2="-106" y1="35" y2="-36" font="Vera.ttf:22,85" color="MenuTxtFG">{MenuText}</scrolltext> <scrolltext condition="not(equal({MenuTitle:clean},trans('Summary')))" x1="10" x2="-106" y1="35" y2="-36" font="VeraMono.ttf:22,85" color="MenuTxtFG">{MenuText}</scrolltext> </block> + + <block condition="{RecordingDescription}"> + <!-- background --> + <rectangle x1="0" x2="-95" y1="30" y2="93" color="MenuAltBG"/> + <rectangle x1="0" x2="-1" y1="94" y2="-31" color="MenuAltBG"/> + + <scrolltext condition="equal({MenuTitle:clean},trans('Recording'))" x1="10" x2="-106" y1="35" y2="-36" font="Vera.ttf:22,85" color="MenuTxtFG">{RecordingTitle}: {RecordingDescription}</scrolltext> + <scrolltext condition="not(equal({MenuTitle:clean},trans('Recording')))" x1="10" x2="-106" y1="35" y2="-36" font="VeraMono.ttf:22,85" color="MenuTxtFG">{RecordingTitle}: {RecordingDescription}</scrolltext> + </block> <!-- Show recordings (in all menus except 'Extended EPG-info' and 'MenuText') --> <block condition="and(not({PresentTitle}),not({MenuText}),{CurrentRecording})">
En/na C.Y.M ha escrit:
It appears that text2skin now has support for vdr-1.3.25 in cvs. Thanks!
2005-06-xx: Version 1.1
- fixed a race condition (thanks to Reinhard Nissl for pointing this out)
- updated finnish translations (thanks to Rolf Ahrenberg)
- added tokens for Recording Info Display (RecordingName, RecordingDateTime, RecordingTitle, RecordingShortText, RecordingDescription, RecordingLanguageCode, RecordingLanguageDescription)
It appears they didn't apply the patch I sent to fix icons display for menu items after the 9th (i.e. without a number in front) :-(
Luca Olivetti wrote:
En/na C.Y.M ha escrit:
It appears that text2skin now has support for vdr-1.3.25 in cvs. Thanks!
2005-06-xx: Version 1.1
- fixed a race condition (thanks to Reinhard Nissl for pointing this out)
- updated finnish translations (thanks to Rolf Ahrenberg)
- added tokens for Recording Info Display (RecordingName, RecordingDateTime, RecordingTitle, RecordingShortText, RecordingDescription, RecordingLanguageCode,
RecordingLanguageDescription)
It appears they didn't apply the patch I sent to fix icons display for menu items after the 9th (i.e. without a number in front) :-(
I did not apply this patch, yet the icons are still displayed after the 9th position when I select the main menu. Can you please explain what this patch does?
Best Regards,
C.Y.M wrote:
Luca Olivetti wrote:
En/na C.Y.M ha escrit:
It appears that text2skin now has support for vdr-1.3.25 in cvs. Thanks!
2005-06-xx: Version 1.1
- fixed a race condition (thanks to Reinhard Nissl for pointing this out)
- updated finnish translations (thanks to Rolf Ahrenberg)
- added tokens for Recording Info Display
(RecordingName, RecordingDateTime, RecordingTitle, RecordingShortText, RecordingDescription, RecordingLanguageCode, RecordingLanguageDescription)
It appears they didn't apply the patch I sent to fix icons display for menu items after the 9th (i.e. without a number in front) :-(
I did not apply this patch, yet the icons are still displayed after the 9th position when I select the main menu. Can you please explain what this patch does?
Maybe the reason I am not seeing this problem is because I'm using a patch for vdr that adds circular scrolling to the menu (ie; if i scroll all the way down in the menu, it returns back to the top, and vice versa). The menu items here do not stop numbering after "9" (ie; I have 20 menu items and vdr numbers them all the way up to 20).
Best Regards,
C.Y.M wrote:
It appears they didn't apply the patch I sent to fix icons display for menu items after the 9th (i.e. without a number in front) :-(
I did not apply this patch, yet the icons are still displayed after the 9th position when I select the main menu. Can you please explain what this patch does?
With enigma the icon in the upper right changes based on the selected item of the menu. If it finds a match will show a specific icon, otherwise it will show the generic vdr icon. Without the patch a menu item after the 9th never matches because it has a space in front (just checked).
Bye
-
Adrian P Challinor -
Anssi Hannula -
C.Y.M -
Luca Olivetti -
Stefan Taferner