Cx88 Color problem patch

On 28 April, Sami Kiiskila wrote to the v4l mailing list about a color problem on cx88 chips:

Do you see any difference in these pictures:

http://www.cs.tut.fi/~kiiskils/kuvat/TTV-Testikuva-tv-bad-2005-04-23-19.png

http://www.cs.tut.fi/~kiiskils/kuvat/TTV-Testikuva-tv-ok-2005-04-23-19.png

especially when zoomed to 2x size ?

If you don't then no need to read further  :)

In case you notice something on the color areas and if you are having similar interference in your own recordings then the "patch" is simple.

Change : HLNotchFilter135PAL to HLNotchFilter4xFsc on line 752 of cx88-core.c and recompile (snapshot video4linux-20050310-100754)

Some warnings: - it might break something - the only known format it works for sure is PAL-BG (used in Finland) - hardware is Hauppauge WinTV GO with cx88xx chip

What happens is probably that the HLNotchFilter135PAL is designed for 13.5MHz sampling rate and the driver tolds the chip to use 27 MHz. So the notch frequency is shifted too to 8.866 MHz instead of 4.433 MHz, it doesn't do much good there. So my original guess that the comb filter is not working was wrong, which I couldn't be sure until I tried out both of the notch control registers.

If the sampling really is done at 27MHz then similar fix would propably help with NTSC too, just change HLNotchFilter135NTSC. But I can't test that here.

Added 2005-04-29:

I tested it on American NTSC using DViCO HDTV 3 Gold hardware. It functions properly. 
I don't have a test pattern to be able to determine if there is an immprovement, but it seems better.