[linux-dvb] Getting in shape for 2.6

[Michael Hunold <hunold@convergence.de>]

Hello all,

Linus Torvalds said on lkml:

-----------------------schnipp----------------------------
Ok. This is it. We (Andrew and me) are going to start a "pre-2.6" 
series, where getting patches in is going to be a lot harder. This is 
the last 2.5.x kernel, so take note.
-----------------------schnipp----------------------------

In a reply he said later on:
-----------------------schnipp----------------------------
I worry a lot more about device drivers etc than I do about
the scheduler.
-----------------------schnipp----------------------------

So, I'm going to step him onto the feet and push the latest changes of 
the dvb-kernel CVS to him.

Additionally, it should be possible to add the latest usb and bt878 
based drivers. But, there are still some issues:

1) Why was tda10045h.c renamed to tda1004x.c? Does it support other 
frontends besides the tda10045h now?

If so, what about the firmware? Do other chipsets need a different one? 
If so, the driver should be split up instead.

Anyway, Robert, Andrew, please change the description in the file.

2) Do the "skystar", "ttusb-dec" and "ttusb-budget" can be selected in 
the kernel make process and compiled under 2.5.x flawlessly?

I'm especially interested in the usb drivers, because the usb subsystem 
has changed in 2.5.

Do they work under 2.5.? I'd like to have one positive feedback for each 
of these drivers, otherwise I won't submit them. Nobody I know 
personally has any of these devices, so please give a feedback.

3) The "skystar.c" driver has some ugly coding style violations like 
comments formatted like this:

-----------------------schnipp----------------------------
/////////////////////////////////////////////////////////////////////
//                      I2C
////////////////////////////////////////////////////////////////////
-----------------------schnipp----------------------------
and
-----------------------schnipp----------------------------
    if ( ( PidGetEmmPID(adapter) & 0x1FFF ) == 0x1FFF )
    {
-----------------------schnipp----------------------------

I'm not a coding style fascist either, but it's Linus' kernel and when 
we want to participate, we have to play the rules.

Does anybode feel responsible to clean this up?

4) The same goes to "ttusb_dec.c":
-----------------------schnipp----------------------------
static int
ttusb_dec_av_pes2ts_cb(void *priv, unsigned char *data)
-----------------------schnipp----------------------------
should be
-----------------------schnipp----------------------------
static int ttusb_dec_av_pes2ts_cb(void *priv, unsigned char *data)
-----------------------schnipp----------------------------
and there are lots of unnecessary blank lines in there, especially after 
opening and closing braces.

Alex, can you clean this up please?

5) Same goes to "dvb-ttusb-budget.c":

-----------------------schnipp----------------------------
static
int ttusb_update_lnb (struct ttusb *ttusb)
-----------------------schnipp----------------------------

Some more stuff:
-----------------------schnipp----------------------------
        u8 b [12] = { 0xaa, ++ttusb->c, 0x18};
-----------------------schnipp----------------------------
Looks unusual to my eyes.

-----------------------schnipp----------------------------
#include "dvb_usb_compat.h"
-----------------------schnipp----------------------------
Can this be put into "dvb_functions.h"?

6) Some comments for "dvb-bt8xx.c":
- lots of blank lines after opening and closing braces
- are the bttv-patches still up to date? If so, I'll resubmit them to 
Gerd Knorr.
- please remove the duplicated bt848.h header file, perhaps add the 
media/video directory as an include path in the Makefile

That's it for now.

CU
Michael.




--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.