Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: [PATCH] dvb-ttpci+budgetpatch no rps on init



On Sun, Jan 09, 2005 at 11:12:21PM +0100, Johannes Stezenbach wrote:
> emard@softhome.net wrote:
> > during initialization of saa7146 I'd suggest
> > to also stop rps with dma, but that's not enough.
> > 
> > I think better initialization procedure would be
> > as follows (not included in this patch)
> > 
> > 1. stop all rps
> > 2. prevent all irq's
> > 3. stop all dma's
> 
> Maybe MiHu can comment on this. Fir now I've committed your patch.

we can even do this:
for(i = 0; i < 2; i++)
{
stop irq
stop dma & rps 
}

First pass is aimed at shutdown of runaway rps, (doesn't hurt to
stop dma by the way it's in the same register) and second one 
assures no more rps is running (that theoretically could re-enable
dma, who knows what previous drivers were using it for) and then 
in the second pass we are sure that we don't have rps, only then
we can be sure to stop irq and get rid of dma too.

Emard




Home | Main Index | Thread Index