[vdr] Re: ShowReplayMode bug (was Re: Video Disk Recorder version 0.97)

[huels@iname.com (Stefan Huelswitt)]

On 27 Oct 2001 Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> wrote:

> ---
>  menu.c      2001/10/21 14:28:14     1.131
> +++ menu.c      2001/10/27 10:20:04
> @@ -2365,6 +2365,8 @@
>  cReplayControl::~cReplayControl()
>  {
>    Hide();
> +  if (Setup.ShowReplayMode)
> +     Hide(); // the initial Hide() may have reopened the small mode display window
>    dvbApi->StopReplay();
>  }


I think this doesn't fixes the problem if you starts cutting
process or if you opens main menu when the progress bar (big
window) is open. In this case the destructor is not called.
And what about the blue key?

In my patch:
 
>> @@ -2664,7 +2664,7 @@
>> 
>>  void cReplayControl::EditCut(void)
>>  {
>> -  Hide(true);
>> +  Hide();
>>    if (!cVideoCutter::Active()) {
>>       if (!cVideoCutter::Start(fileName))
>>          Interface->Error(tr("Can't start editing process!"));

and

>> @@ -2727,7 +2727,7 @@
>>      case kGreen:   dvbApi->SkipSeconds(-60); break;
>>      case kYellow|k_Repeat:
>>      case kYellow:  dvbApi->SkipSeconds( 60); break;
>> -    case kBlue:    Hide(true);
>> +    case kBlue:    Hide();
>>                     dvbApi->StopReplay();
>>                     return osEnd;
>>      default: {

and

>> @@ -2748,7 +2748,7 @@
>>            displayFrames = DisplayedFrames;
>>            switch (Key) {
>>              // Menu control:
>> -            case kMenu:    Hide(true); return osMenu; // allow direct switching to menu
>> +            case kMenu:    Hide(); return osMenu; // allow direct switching to menu
>>              case kOk:      if (visible && !modeOnly)
>>                                Hide();
>>                             else

-- 
Stefan Huelswitt
huels@iname.com  | http://home.pages.de/~nathan