[vdr] Re: vdr-1.2.2-libsi.patch

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Rolf Hakenes wrote:
> 
> Hi Klaus,
> 
> crc32 is used through some modules within the library, therefore it
> should not be static.

Hmmm...

kls@hawk2:/home/kls/vdr/VDR/libdtv > grep -w crc32 `find -name '*.[hc]'`
./libsi/include/libsi.h:u_long crc32 (char *data, int len);
./libsi/si_parser.c:   if (crc32 (Ptr, HILO (Pat->section_length) + 3)) return (NULL);
./libsi/si_parser.c:   if (crc32 (Ptr, HILO (Cat->section_length) + 3)) return (NULL);
./libsi/si_parser.c:   if (crc32 (Ptr, HILO (Pmt->section_length) + 3)) return (NULL);
./libsi/si_parser.c:   if (crc32 (Ptr, HILO (Nit->section_length) + 3)) return (NULL);
./libsi/si_parser.c:   if (crc32 (Ptr, HILO (Sdt->section_length) + 3)) return (NULL);
./libsi/si_parser.c:   if (crc32 (Ptr, HILO (Eit->section_length) + 3)) return (NULL);
./libsi/si_parser.c:   if (crc32 (Ptr, HILO (Tot->section_length) + 3)) return (NULL);
./libsi/si_parser.c:u_long crc32 (char *data, int len)
./libdtv.h:u_long crc32 (char *data, int len);

If I'm not completely missing something here, the only place where crc32() is
used is _in_ si_parser.c.

But I don't mean to start a debate here, just wanted to point out this alternative
possibility (and wouldn't mind if somebody told me in case I actually _did_ miss
something here).

I'll apply the patch.

Klaus


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.