Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[vdr] Re: svdrp - Bug or Feature or my fault



Klaus Schmidinger wrote:

The only difference I see is in line 1103 - in svdrp.c - should
this be "reverted"?

Yes, please try that. The diff between version 1.2.1 and 1.2.2 was

--- svdrp.c     2003/06/06 13:30:52     1.52
+++ svdrp.c     2003/07/26 10:57:33     1.53
@@ -1100,7 +1100,7 @@
                  }
               lastActivity = time(NULL);
               }
-           else if (r <= 0) {
+           else if (r < 0) {
               isyslog("lost connection to SVDRP client");
               Close();
               }
After a closer look I think, the old version is better
  else if (r <= 0)

reason 1: Otherwise it is undefined, what to do with r == 0
reason 2: The old version works reliable. Nothing went wrong
in the last 15 hours.

Might be there is a reason for the new version of svdrp.c
But in that case a test for r == 0 should be inserted.

regards
Wolfgang





--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.



Home | Main Index | Thread Index