[vdr] Re: Bugreport: Games-Plugin

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Juri Haberland wrote:
> 
> ...
> There's a design problem:
> Make.config can be used to override some settings, e.g. the location of
> the DVB dir. This is done with a perspective from the VDR dir. The
> plugins include this file but have a perspective of
> VDR/PLUGINS/src/<plugin>/. If a path in Make.config isn't absolute the
> plugin will fail.
> 
> As nearly all plugins seem to include Make.config the question arises,
> why only some plugins fail to compile whereas other compile
> successfully. I think this is because those plugins that compile don't
> actually use any header files from DVB or those of VDR that reference
> DVB header files.
> 
> If I comment out the line with DVBDIR in Make.config all plugins
> compile. If I change it to an absolute path all plugins compile, too -
> besides the new games-plugin - see attached patch for games-0.6.0.
> 
> I propose to overcome this problem in the future to comment out the
> DVBDIR line in Make.config.template and additionally to change it to an
> absolute path. Patch also attached.
> ...
----------------------------------------------------------------------------------
> --- VDR.old/Make.config.template        2003-08-09 13:03:25.000000000 +0200
> +++ VDR/Make.config.template    2003-09-20 13:30:20.000000000 +0200
> @@ -18,7 +18,7 @@
> 
>  ### The directory environment:
> 
> -DVBDIR   = ../DVB
> +# DVBDIR   = /usr/src/DVB
>  MANDIR   = /usr/local/man
>  BINDIR   = /usr/local/bin
> 

Wouldn't it be better to define a default location for the driver's
header files and have the driver's Makefile copy them there in 'make install'?

I just looked through the driver's Makefile(s), but didn't see any place where
a 'make install' would copy the header files to a commonly used location, like
/usr/include/dvb or so. Once the driver specifies such a default location,
that one should be used in the default Make.config.template of VDR. 

Klaus


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.