Stefan Huelswitt wrote:
On 14 Jan 2006 Klaus Schmidinger Klaus.Schmidinger@cadsoft.de wrote:
Stefan Huelswitt wrote:
Actualy it allows overwriting files with no extention only.
I find it convinient to be backward compatible. As the whole operation is limited to the grab directory anyways, security considerations are negligible IMHO.
And what's the point in writing to a file without an extension?
For me the point was, that vdradmin uses a grab file without extention since ever. vdr 1.3.38 broke that.
I think it's a good idea to behave in a backward compatible way whenever possible.
Jut my 2 cents.
Ok, since there have been no other voices on this, and personally I don't really care, I've removed the entire 'else' clause, since Jpeg is true by default:
--- svdrp.c 2006/01/14 14:55:52 1.92 +++ svdrp.c 2006/01/14 16:08:20 @@ -683,10 +683,6 @@ } else if (strcmp(FileName, "-") == 0) FileName = NULL; - else { - Reply(501, "Missing filename extension in "%s"", FileName); - return; - } // image quality (and obsolete type): if ((p = strtok_r(NULL, delim, &strtok_next)) != NULL) { if (strcasecmp(p, "JPEG") == 0 || strcasecmp(p, "PNM") == 0) {
However, this still doesn't allow names with '.' that don't end in one of the known extensions. But then again I would assume that programs connecting to an SVDRP port will switch to using the base64 encoded data sent over the port.
Klaus