Matthias Lötzke wrote:
Klaus.Schmidinger@cadsoft.de says...
- complete rewrite of the LNB-sharing code in cDevice::GetDevice() to fit that somewhat cryptic new code in the VDR source
What's "cryptic" about it?
Bit shifting and bit manipulating code like
[...] imp <<= 8; imp |= min(max(device[i]->Priority() + MAXPRIORITY, 0), 0xFF); imp <<= 8; imp |= min(max(device[i]->ProvidesCa(Channel), 0), 0xFF); [...]
is hard to read and makes it difficult to understand the whole algorithm without documentation. Personally I prefer to use bit manipulating operations only where it is unavoidable.
Well, I thought that this new GetDevice() function was pretty short and self-explaining. And, most of all, it actually works as expected ;-)
Would you like to suggest a version that doesn't use bit manipulation, is as short as the current one, and also works correctly?
Klaus