On 31.03.2011 15:40, Rainer Blickle wrote:
2011/3/30 Steffen Barszussteffenbpunkt@googlemail.com:
2011/3/30 Oliver Schinagloliver@schinagl.nl:
I belive that is exactly only what this patch does, it changes the positions on the screen for the ST-NG theme I think (it's been a while I admit).
So if VDR is told that the red button performs the job of the red button, then everything is ok.
To recap, the problem I had with VDR that caused me to write this patch, was:
My Remote control had 2 buttons different from where VDR expected the buttons to be. E.g. VDR wants Red Yellow Green Blue, but my remote control was Red Yellow Blue Green.
My remote has the color order Yellow, Red, Blue, Green (only an example, i dont have the remote at hand). Lets say the buttons are Button0, Button1, Button2, Button3
When learning, vdr wants the keys Red,Yellow, Green, Blue to get pressed.
In the vdr layout Button0 is Red, Button1 is Yellow and so on ... while watching a recording vdr jumps 1 minute in the past when pressing yellow and one minute in the future when pressing green. These are the "middle" color buttons.
I also wanted to have this functionality in the "middle" buttons (on the buttons 1 and 2).
So i pressed the Buttons Yellow, Red, Blue, Green while learning Red,Yellow, Green, Blue. Then i have the jumping +/-1 Minute functionality still on the middle color buttons.
The only thing left is that the color on the osd has to be adjusted, but not the positions of the text on it. If have dont this by modifying your patch (the texts for ->DrawText are taken directly from the parameters, not from the mapping).
My (and perhaps only my) opinion is that vdr should request the leftmost color button, then the color right next to it (and so on) while learning. The color displayed in the osd should be assigned via the setup menu.
@Klaus: If there is a change to integrate this into the vdr, i would provide a patch for it.
I assume you meant a "chance" ;-)
Well, as stated earlier, i'd be willing to accept a patch that rearranges the sequence of the color buttons on the OSD, to make them match the sequence on the remote control. What I don't like is to mess with the actual functionality of the color buttons, because that would cause a "babylonification". If somebody asks "how do I do this or that", the answer could no longer be "press the green button", but would rather have to be "press the second button from the left in the row of color buttons, provided they are arranged in a row at all" ;-) It would also have a major impact on all sorts of documentation, and all source code that currently uses kRed, kGreen, kYellow and kBlue would have to be modified.
Klaus