Marko Mäkelä wrote:
On Tue, Jan 23, 2007 at 10:19:57PM +0100, Udo Richter wrote:
Since the shutdown script runs in the background, the stdin could probably be closed. After all, VDR should continue to 'own' stdin, and running in the background would probably cause a conflict. However, running the script with a closed file handle may cause other side effects.
I can't think of any side effect. The shutdown script is not supposed to be interactive, and system tools generally do not read stdin.
Well, strange things happen. I've had such a side effect on my runvdr extreme with a closed stdout, see here: (German) http://www.vdr-portal.de/board/thread.php?postid=542948#post542948
In this case, printf on kanotix complained heavily on a closed stdout, and the only workaround was to replace >&- with the traditional >/dev/null.
Are you planning to maintain the 1.4 branch of the patch? If yes (and I hope so), can plugins use some #ifdef to see if Shutdown.IsUserInactive() is available?
For now I'll maintain it, currently the differences are only minor. Adding some #ifdef detection is a good idea, I'll add that for the next 1.4 patch.
Cheers,
Udo