Hi Klaus,
What about adding a possibility to skip ±5 or ±10 seconds when replaying a recording?
Would you perhaps accept a patch for the developer version?
That would be nice.
Peter Münster pmlists@free.fr writes:
Hi Klaus,
What about adding a possibility to skip ±5 or ±10 seconds when replaying a recording?
Would you perhaps accept a patch for the developer version?
Bonjour,
i've added this to menu.c : case k5|k_Repeat: case k5: SkipSeconds(240); break; case k1|k_Repeat: case k1: SkipSeconds(-10); break; case k3|k_Repeat: case k3: SkipSeconds( 10); break;
k5 to skip itv adverts when watching corrie recordings :)
I've been too lazy to think of a configurable way of doing it.
On 01.04.2014 13:29, Peter Münster wrote:
On Mon, Mar 31 2014, Peter Münster wrote:
What about adding a possibility to skip ±5 or ±10 seconds when replaying a recording?
Would you perhaps accept a patch for the developer version?
Hi Klaus,
What about the attached patch?
There are several things I don't like about it ;-).
First and foremost I don't think that we need extra keys for jumping such short distances as 5 or 10 seconds. Just use "fast forward" or "fast rewind" for that. What I would be willing to accept is a patch that makes the skip delta of the yellow and green keys (currently a fixed +/-60s) configurable. I might even go as far as making the yellow and green keys skip only a small distance when pressed and released, and skipping a longer distance when held pressed (repeat mode). It could even be made so that the distance increases over time, so the longer you hold the key pressed, the farther it skips. However, this might not be very practical because when skipping with repeat there is no video displayed because the buffer gets cleared all the time. This is a general problem I'm hoping to be able to address at some time.
All in all, skipping is done with the yellow and green keys, there will be no additional keys for "shirt skips", because FFWD/FREW can easily be used for that. Let's keep it simple! ;-)
Klaus
On Sun, Apr 06 2014, Klaus Schmidinger wrote:
First and foremost I don't think that we need extra keys for jumping such short distances as 5 or 10 seconds. Just use "fast forward" or "fast rewind" for that.
Have you tried 5s steps? I really prefer 5s steps over fast forward/rewind. With mplayer-plugin I have 6 buttons for 5s steps, 1min steps and 10min steps, and IMO you skip faster to the right place, than with fast forward/rewind. Perhaps it's just me...
What I would be willing to accept is a patch that makes the skip delta of the yellow and green keys (currently a fixed +/-60s) configurable.
Yes, that's fine. But what's the problem with a second skip-value for buttons 1 and 3?
I might even go as far as making the yellow and green keys skip only a small distance when pressed and released, and skipping a longer distance when held pressed (repeat mode). It could even be made so that the distance increases over time, so the longer you hold the key pressed, the farther it skips.
For adjusting a clock, it's perhaps ok, but IMO for audio/video it's not the best ergonomics.
All in all, skipping is done with the yellow and green keys, there will be no additional keys for "shirt skips", because FFWD/FREW can easily be used for that. Let's keep it simple! ;-)
I agree to keep it simple. But would you approve a patch, that adds just one further key pair (1 + 3) for a second skip value? The patch would be really simpler and the user experience would be enhanced!
Or a Boolean configuration option for making 5s-skips instead of fast forward/rewind?
What I would be willing to accept is a patch that makes the skip delta of the yellow and green keys (currently a fixed +/-60s) configurable.
Yes, that's fine. But what's the problem with a second skip-value for buttons 1 and 3?
If the skip amount can configurable then each user can set it to his own liking and no extra buttons needed. That seems like the simplest & best solution in my opinion. Can you think of any setup that actually uses several skip buttons? Skipping doesn't need to be complicated or require a handful of buttons. Allow the user to set his preferred skip+ and skip- amounts, and done deal. :)
On Sun, Apr 06 2014, VDR User wrote:
What I would be willing to accept is a patch that makes the skip delta of the yellow and green keys (currently a fixed +/-60s) configurable.
Yes, that's fine. But what's the problem with a second skip-value for buttons 1 and 3?
If the skip amount can configurable then each user can set it to his own liking and no extra buttons needed. That seems like the simplest & best solution in my opinion. Can you think of any setup that actually uses several skip buttons? Skipping doesn't need to be complicated or require a handful of buttons. Allow the user to set his preferred skip+ and skip- amounts, and done deal. :)
The question was "What's the problem?". Do you have an answer? Of course the default setting can be "no second skip-value", nothing would change for users. But for my personal setup I'll use 2 buttons for 5s-steps and 2 buttons for 60s-steps. If I could do that without patching VDR, that would be really nice.
On Sun, 06 Apr 2014 21:26:08 +0200 Peter Münster pmlists@free.fr wrote:
On Sun, Apr 06 2014, VDR User wrote:
What I would be willing to accept is a patch that makes the skip delta of the yellow and green keys (currently a fixed +/-60s) configurable.
Yes, that's fine. But what's the problem with a second skip-value for buttons 1 and 3?
If the skip amount can configurable then each user can set it to his own liking and no extra buttons needed. That seems like the simplest & best solution in my opinion. Can you think of any setup that actually uses several skip buttons? Skipping doesn't need to be complicated or require a handful of buttons. Allow the user to set his preferred skip+ and skip- amounts, and done deal. :)
The question was "What's the problem?". Do you have an answer? Of course the default setting can be "no second skip-value", nothing would change for users. But for my personal setup I'll use 2 buttons for 5s-steps and 2 buttons for 60s-steps. If I could do that without patching VDR, that would be really nice.
+1 for more skipping choices and making the size of the steps configurable.
ludi
On 06.04.2014 19:06, Peter Münster wrote:
On Sun, Apr 06 2014, Klaus Schmidinger wrote:
First and foremost I don't think that we need extra keys for jumping such short distances as 5 or 10 seconds. Just use "fast forward" or "fast rewind" for that.
Have you tried 5s steps? I really prefer 5s steps over fast forward/rewind. With mplayer-plugin I have 6 buttons for 5s steps, 1min steps and 10min steps, and IMO you skip faster to the right place, than with fast forward/rewind. Perhaps it's just me...
Perhaps... ;-).
What I would be willing to accept is a patch that makes the skip delta of the yellow and green keys (currently a fixed +/-60s) configurable.
Yes, that's fine. But what's the problem with a second skip-value for buttons 1 and 3?
Keys on the remote control are a very limited resource, and I wouldn't want to waste two of them for a function that is not really necessary.
I might even go as far as making the yellow and green keys skip only a small distance when pressed and released, and skipping a longer distance when held pressed (repeat mode). It could even be made so that the distance increases over time, so the longer you hold the key pressed, the farther it skips.
For adjusting a clock, it's perhaps ok, but IMO for audio/video it's not the best ergonomics.
Well, then I'll leave it as is. This was just an idea...
All in all, skipping is done with the yellow and green keys, there will be no additional keys for "shirt skips", because FFWD/FREW can easily be used for that. Let's keep it simple! ;-)
I agree to keep it simple. But would you approve a patch, that adds just one further key pair (1 + 3) for a second skip value?
No (see above).
The patch would be really simpler and the user experience would be enhanced!
Or a Boolean configuration option for making 5s-skips instead of fast forward/rewind?
Well, that's something we can talk about. You could make it so that during replay the Left and Right keys perform 5s skips, and the FastForward/-Rewind keys (if present on the user's remote control) still retain their normal function.
Klaus
On 04/07/2014 12:20 PM, Klaus Schmidinger wrote:
Well, that's something we can talk about. You could make it so that during replay the Left and Right keys perform 5s skips, and the FastForward/-Rewind keys (if present on the user's remote control) still retain their normal function.
This kind of behavior sounds like a good compromise and no new keys are needed. I also currently use a patch that adds shorter skips to keys 1 and 3 and there I see no reason why Left and Right would not be equally as good. I rarely use FastForward/-Rewind anyway. For those who prefer FastForward/-Rewind and have no separate keys available the setup option would make it possible.
-Matti
Well, that's something we can talk about. You could make it so that during replay the Left and Right keys perform 5s skips, and the FastForward/-Rewind keys (if present on the user's remote control) still retain their normal function.
This kind of behavior sounds like a good compromise and no new keys are needed.
Agreed. Although, I still like the idea of users being able to set their own values.
On Mon, 07 Apr 2014 12:20:37 +0200 Klaus Schmidinger Klaus.Schmidinger@tvdr.de wrote:
Well, that's something we can talk about. You could make it so that during replay the Left and Right keys perform 5s skips, and the FastForward/-Rewind keys (if present on the user's remote control) still retain their normal function.
That sounds like a good idea. We should also discuss making it assymetric ie right could skip forwards 10 seconds and left could go back 5s. That way you can skip through the adverts in fewer steps until you see you've overrun, then do a half skip backwards to get close to the right place. Totem has assymetric skipping, although I think it's something like 60s and 15s-20s. Anyway, I find that useful.
On 06.04.2014 19:06, Peter Münster wrote:
On Sun, Apr 06 2014, Klaus Schmidinger wrote:
First and foremost I don't think that we need extra keys for jumping such short distances as 5 or 10 seconds. Just use "fast forward" or "fast rewind" for that.
Have you tried 5s steps? I really prefer 5s steps over fast forward/rewind. With mplayer-plugin I have 6 buttons for 5s steps, 1min steps and 10min steps, and IMO you skip faster to the right place, than with fast forward/rewind. Perhaps it's just me...
Perhaps... ;-).
Definitely not :) My kids and I are using the keys 1 and thre and yellow and green very often, because it makes skipping much faster.
Yes, that's fine. But what's the problem with a second skip-value for buttons 1 and 3?
Keys on the remote control are a very limited resource, and I wouldn't want to waste two of them for a function that is not really necessary.
??? Why is it a waste using two unused keys ? I would say its a waste not using those :)
But anyway the patch for that behaviour is easy to implement, so from my point of view, I do not miss it in plain VDR because I know how to patch it :)
Helmut
On 07.04.2014 17:44, Helmut Auer wrote:
On 06.04.2014 19:06, Peter Münster wrote:
On Sun, Apr 06 2014, Klaus Schmidinger wrote:
First and foremost I don't think that we need extra keys for jumping such short distances as 5 or 10 seconds. Just use "fast forward" or "fast rewind" for that.
Have you tried 5s steps? I really prefer 5s steps over fast forward/rewind. With mplayer-plugin I have 6 buttons for 5s steps, 1min steps and 10min steps, and IMO you skip faster to the right place, than with fast forward/rewind. Perhaps it's just me...
Perhaps... ;-).
Definitely not :) My kids and I are using the keys 1 and thre and yellow and green very often, because it makes skipping much faster.
Yes, that's fine. But what's the problem with a second skip-value for buttons 1 and 3?
Keys on the remote control are a very limited resource, and I wouldn't want to waste two of them for a function that is not really necessary.
??? Why is it a waste using two unused keys ? I would say its a waste not using those :)
If I officially use them for a function that is (IMHO, agreed) unnecessary, then they would be wasted for future use for functions that might be more important ;-).
Klaus
If I officially use them for a function that is (IMHO, agreed)
unnecessary, then they would be wasted for future use for functions that might be more important ;-).
Well these keys are unused for 14 years now and yes, they could be saved for any usage another 14 years, ..., doing nothing ... ^^
I agree with all supporters, I like that function, and them on discrete keys. I would also not have problems to patch it further. But it's also ok to use other discrete keys, e.g. the proposed usage of right/left in replay mode, just to find a global agreement for core VDR.
Maybe there's a way to make it definable for the rare cases an user doesn't have a remote with discrete fastfwd/fastrwd keys ...
In the many years of using VDR I rarly used fastfwd/fastrew, since jumping a few seconds is much more comfortable and therfore important to me.
=== Kind regards fnu
Am Montag, 7. April 2014, 12:20:37 schrieb Klaus Schmidinger:
Well, that's something we can talk about. You could make it so that during replay the Left and Right keys perform 5s skips, and the FastForward/-Rewind keys (if present on the user's remote control) still retain their normal function.
I would welcome that. When watching a HD recording over xineliboutput, fastforward/rewind never stops when I stop but goes on until it skipped about one minute.
Of course I hear you saying "get xineliboutput fixed" but discrete 5s skips would certainly solve that problem.
On Mon, Apr 07 2014, Klaus Schmidinger wrote:
Or a Boolean configuration option for making 5s-skips instead of fast forward/rewind?
Well, that's something we can talk about. You could make it so that during replay the Left and Right keys perform 5s skips, and the FastForward/-Rewind keys (if present on the user's remote control) still retain their normal function.
Thank you! Please find attached a new patch.
Am 31.03.2014 11:42, schrieb Peter Münster:
What about adding a possibility to skip ±5 or ±10 seconds when replaying a recording?
BTW: The liemikuutio Patch set does have Binary Search (half jump width on each direction reversal). Around 4 lines of code to make it the perfect skipper. I guess most distris use that and so nobody cares...
-
fnu -
Helmut Auer -
Klaus Schmidinger -
Ludi -
Mario Schulz -
Matti Lehtimäki -
Peter Münster -
syrius.ml＠no-log.org -
Tony Houghton -
VDR User -
Wolfgang Rohdewald