VDR developer version 1.7.27 is now available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.27.tar.bz2
A 'diff' against the previous version is available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.26-1.7.27.diff
MD5 checksums:
bfeaa79a9e55144bca2b69139c45f1bb vdr-1.7.27.tar.bz2 b23344be51d3e2c2d96cc2dd4e8e564e vdr-1.7.26-1.7.27.diff
WARNING: ========
This is a *developer* version. Even though *I* use it in my productive environment. I strongly recommend that you only use it under controlled conditions and for testing and debugging.
The changes since version 1.7.26:
- Updated the Finnish OSD texts (thanks to Rolf Ahrenberg). - Changed the Green button in the "Edit timer" menu from "Once" to "Single" (suggested by Rolf Ahrenberg). - Fixed some typos in HISTORY and CONTRIBUTORS (thanks to Ville Skyttä). - The channel name column in the "What's on now/next" menu now adjusts its width to display the full short name of each channel (suggested by Dominic Evans). - Dropped the meanwhile obsolete script 'i18n-to-gettext'. - Removed the obsolete function cPlugin::RegisterI18n(). - Removed the obsolete typedef tI18nPhrase. - Adapted menu column widths of 'skincurses' to the wider HD OSD sizes. - Deactivated definition of __RECORDING_H_DEPRECATED_DIRECT_MEMBER_ACCESS (recording.h) and LEGACY_CRECEIVER (receiver.h) to trigger an error for any plugin that still uses the respective code. You can reactivate these to quickly make your plugin compile again, but beware that these code parts will be removed in one of the next versions. - Made the "overloaded-virtual" warning an error to detect hidden overloaded virtual functions (thanks to Anssi Hannula for pointing out -Werror=...). Plugin authors may want to change -Woverloaded-virtual to -Werror=overloaded-virtual in their Makefiles. - Updated the Estonian OSD texts (thanks to Arthur Konovalov). - Improved fast forwarding to the end of a timeshift recording. - The new function cDevice::DeviceName() returns a string identifying the name of the given device. - When toggling a timer between "Single" and "Repeating", the previous setting is now retained in case the user toggles back to the original value. - When estimating the remaining disk space (in hours), the average data rate of all existing recordings is now taken into account. If this value can't be determined, the previous value of 25.75 MB/min is taken. - No longer using GetFont() (which is not thread safe) in the 'osddemo' plugin. - No longer using GetFont() (which is not thread safe) in cSubtitleRegion::UpdateTextData(). - Fixed a memory leak in cSubtitleRegion::UpdateTextData(). - Moved setting LC_NUMERIC further up to make sure any floating point numbers use a decimal point (suggested by Tobias Grimm). - Added missing channel locking to cEIT. - Fixed reduced bpp support for DVB subtitles (thanks to Rolf Ahrenberg). - Updated the Italian OSD texts (thanks to Diego Pierotto). - Reverted some improvements to Make.config.template (thanks to Christian Ruppert). - Fixed handling IDLEPRIORITY in cDvbDevice::ProvidesChannel() (thanks to Frank Schmirler).
Have fun!
Klaus
On 25 March 2012 12:45, Klaus Schmidinger Klaus.Schmidinger@tvdr.de wrote:
- The channel name column in the "What's on now/next" menu now adjusts its
width to display the full short name of each channel (suggested by Dominic Evans).
Superb! Many thanks!
On 26 March 2012 10:25, Dominic Evans oldmanuk@gmail.com wrote:
On 25 March 2012 12:45, Klaus Schmidinger Klaus.Schmidinger@tvdr.de wrote:
- The channel name column in the "What's on now/next" menu now adjusts its
width to display the full short name of each channel (suggested by Dominic Evans).
Superb! Many thanks!
Unfortunately, this doesn't seem to be working. I just upgraded to vdr 1.7.27 and the channel name is now only a single character for every channel.
I tried to grab a screenshot, but xine seems to be refusing to with '[xine..put] cXinelibServer::Grab: Grab failed (0)'
On Sat, Mar 31, 2012 at 4:10 PM, Dominic Evans oldmanuk@gmail.com wrote:
- The channel name column in the "What's on now/next" menu now adjusts its
width to display the full short name of each channel (suggested by Dominic Evans).
Unfortunately, this doesn't seem to be working. I just upgraded to vdr 1.7.27 and the channel name is now only a single character for every channel.
I had the same problem here as well. Klaus has fixed it, try the patch below:
-------------------- diff -pruN vdr-1.7.27-orig/channels.c vdr-1.7.27/channels.c --- vdr-1.7.27-orig/channels.c 2012-03-25 22:46:14.294920001 -0700 +++ vdr-1.7.27/channels.c 2012-03-28 09:29:23.734920001 -0700 @@ -955,7 +955,7 @@ int cChannels::MaxShortChannelNameLength if (!maxShortChannelNameLength) { for (cChannel *channel = First(); channel; channel = Next(channel)) { if (!channel->GroupSep()) - maxShortChannelNameLength = max(Utf8StrLen(channel->ShortName()), maxShortChannelNameLength); + maxShortChannelNameLength = max(Utf8StrLen(channel->ShortName(true)), maxShortChannelNameLength); } } return maxShortChannelNameLength;
On 1 April 2012 00:54, VDR User user.vdr@gmail.com wrote:
Unfortunately, this doesn't seem to be working. I just upgraded to vdr 1.7.27 and the channel name is now only a single character for every channel.
I had the same problem here as well. Klaus has fixed it, try the patch
Thanks. Have submitted this to the yaVDR guys on github to add to their debian/patches.
Hi Klaus,
On 25 March 2012 12:45, Klaus Schmidinger Klaus.Schmidinger@tvdr.de wrote:
- The channel name column in the "What's on now/next" menu now adjusts its
width to display the full short name of each channel (suggested by Dominic Evans).
With the additional patch to fix the bug with getting a single column width (that I previously mentioned), this still isn't quite working correctly.
See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg
The column has been widened, but the displayed channel names are seemingly cropped to the old width?
BBC ON rather than BBC ONE BBC TW rather than BBC TWO Channe rather than Channel 4 etc.
On 04.04.2012 20:36, Dominic Evans wrote:
Hi Klaus,
On 25 March 2012 12:45, Klaus SchmidingerKlaus.Schmidinger@tvdr.de wrote:
- The channel name column in the "What's on now/next" menu now adjusts its
width to display the full short name of each channel (suggested by Dominic Evans).
With the additional patch to fix the bug with getting a single column width (that I previously mentioned), this still isn't quite working correctly.
See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg
The column has been widened, but the displayed channel names are seemingly cropped to the old width?
BBC ON rather than BBC ONE BBC TW rather than BBC TWO Channe rather than Channel 4 etc.
Are you sure you're using the right version of menu.c? The macro CHNAMWIDTH must be used 3 times there:
#> grep -n CHNAMWIDTH menu.c
52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1) 1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"), CHNUMWIDTH, CHNAMWIDTH, 6, 4) 1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4); 1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
Klaus
On 4 April 2012 21:48, Klaus Schmidinger Klaus.Schmidinger@tvdr.de wrote:
On 04.04.2012 20:36, Dominic Evans wrote:
With the additional patch to fix the bug with getting a single column width (that I previously mentioned), this still isn't quite working correctly.
See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg
The column has been widened, but the displayed channel names are seemingly cropped to the old width?
BBC ON rather than BBC ONE BBC TW rather than BBC TWO Channe rather than Channel 4 etc.
Are you sure you're using the right version of menu.c? The macro CHNAMWIDTH must be used 3 times there:
#> grep -n CHNAMWIDTH menu.c
52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1) 1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"), CHNUMWIDTH, CHNAMWIDTH, 6, 4) 1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4); 1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
Yep. Before applying my quilt series, my menu.c matches yours:
$ grep -n CHNAMWIDTH menu.c 52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1) 1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"), CHNUMWIDTH, CHNAMWIDTH, 6, 4) 1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4); 1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
After applying a few patches, the line numbers have shifted, but the code remains the same:
$ grep -n CHNAMWIDTH menu.c 56:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1) 1550::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"), CHNUMWIDTH, CHNAMWIDTH, 6, 4) 1800: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4); 1819: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
I can re-test with vanilla VDR sources if you think its possible they are causing the issue?
On 04.04.2012 23:08, Dominic Evans wrote:
On 4 April 2012 21:48, Klaus SchmidingerKlaus.Schmidinger@tvdr.de wrote:
On 04.04.2012 20:36, Dominic Evans wrote:
With the additional patch to fix the bug with getting a single column width (that I previously mentioned), this still isn't quite working correctly.
See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg
The column has been widened, but the displayed channel names are seemingly cropped to the old width?
BBC ON rather than BBC ONE BBC TW rather than BBC TWO Channe rather than Channel 4 etc.
Are you sure you're using the right version of menu.c? The macro CHNAMWIDTH must be used 3 times there:
#> grep -n CHNAMWIDTH menu.c
52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1) 1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"), CHNUMWIDTH, CHNAMWIDTH, 6, 4) 1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4); 1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
Yep. Before applying my quilt series, my menu.c matches yours:
$ grep -n CHNAMWIDTH menu.c 52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1) 1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"), CHNUMWIDTH, CHNAMWIDTH, 6, 4) 1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4); 1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
After applying a few patches, the line numbers have shifted, but the code remains the same:
$ grep -n CHNAMWIDTH menu.c 56:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1) 1550::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"), CHNUMWIDTH, CHNAMWIDTH, 6, 4) 1800: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4); 1819: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
I can re-test with vanilla VDR sources if you think its possible they are causing the issue?
It would be a start, jut to make sure. After all, it appears to work fine here.
Klaus
Hi Klaus,
On 4 April 2012 22:53, Klaus Schmidinger Klaus.Schmidinger@tvdr.de wrote:
On 04.04.2012 23:08, Dominic Evans wrote:
I can re-test with vanilla VDR sources if you think its possible they are causing the issue?
It would be a start, jut to make sure. After all, it appears to work fine here.
As suspected, it looks like it was the wareagleicon patch causing the issue. After removing that the Now+Next page is looking good! :-)
Apologies for the confusion. I'll investigate what needs fixing in the icon patch.
On 5 Apr 2012, at 16:26, Dominic Evans oldmanuk@gmail.com wrote:
Hi Klaus,
On 4 April 2012 22:53, Klaus Schmidinger Klaus.Schmidinger@tvdr.de wrote:
On 04.04.2012 23:08, Dominic Evans wrote:
I can re-test with vanilla VDR sources if you think its possible they are causing the issue?
It would be a start, jut to make sure. After all, it appears to work fine here.
As suspected, it looks like it was the wareagleicon patch causing the issue. After removing that the Now+Next page is looking good! :-)
Apologies for the confusion. I'll investigate what needs fixing in the icon patch.
Was an easy fix in the end. Will send it to yavdr guys.
In article 4F6F0570.7050507@tvdr.de you write:
VDR developer version 1.7.27 is now available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.27.tar.bz2A 'diff' against the previous version is available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.26-1.7.27.diff[...]
Hi!
While upgrading from 1.7.22 to 1.7.27 I noticed epg scans on a single tuner (with xineliboutput in this case) no longer seem to happen while that tuner is in live view mode, even trying to force a scan via the osd or via "svdrpsend scan" no longer does anything.
Am I right this is because eitscan.c cEITScanner::Process does
... if (!Device->Receiving()) { ...
and device.c cDevice::Receiving's bool arg no longer does anything i.e. it no longer checks the attached receiver's priorities and thus returns true even for devices only in live view mode?
And if yes, what would be the proper fix? :)
Thanx! Juergen
On 06.04.2012 22:13, Juergen Lock wrote:
In article4F6F0570.7050507@tvdr.de you write:
VDR developer version 1.7.27 is now available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.27.tar.bz2A 'diff' against the previous version is available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.26-1.7.27.diff[...]
Hi!
While upgrading from 1.7.22 to 1.7.27 I noticed epg scans on a single tuner (with xineliboutput in this case) no longer seem to happen while that tuner is in live view mode, even trying to force a scan via the osd or via "svdrpsend scan" no longer does anything.
Am I right this is because eitscan.c cEITScanner::Process does
... if (!Device->Receiving()) { ...
and device.c cDevice::Receiving's bool arg no longer does anything i.e. it no longer checks the attached receiver's priorities and thus returns true even for devices only in live view mode?
And if yes, what would be the proper fix? :)
Please try changing
if (!Device->Receiving()) {
to
if (Device->Priority() < 0) {
Klaus
On Sat, Apr 07, 2012 at 11:39:38AM +0200, Klaus Schmidinger wrote:
On 06.04.2012 22:13, Juergen Lock wrote:
In article4F6F0570.7050507@tvdr.de you write:
VDR developer version 1.7.27 is now available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.27.tar.bz2A 'diff' against the previous version is available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.26-1.7.27.diff[...]
Hi!
While upgrading from 1.7.22 to 1.7.27 I noticed epg scans on a single tuner (with xineliboutput in this case) no longer seem to happen while that tuner is in live view mode, even trying to force a scan via the osd or via "svdrpsend scan" no longer does anything.
Am I right this is because eitscan.c cEITScanner::Process does
... if (!Device->Receiving()) { ...
and device.c cDevice::Receiving's bool arg no longer does anything i.e. it no longer checks the attached receiver's priorities and thus returns true even for devices only in live view mode?
And if yes, what would be the proper fix? :)
Please try changing
if (!Device->Receiving()) {to
if (Device->Priority() < 0) {
Yep, that fixes it, now "svdrpsend scan" works again.
Thanx! :) Juergen
-
Dominic Evans -
Juergen Lock -
Klaus Schmidinger -
VDR User