On Thu, Dec 27, 2007 at 12:42:30AM +0100, Reinhard Nissl wrote:

Hi,

some more patches:

HASHSIZE should be a prime: 512 looks like a typo of 521.

That is related to my original hash patch a few years ago. It is not a typo! If you don't have a special distribution with clusters it doesn't matter if the hash size is prime or not. In fact the modulo operation is slower than the AND on old CPUs...

oprofile and gprof showed the possibilty to speed up some OSD drawing operations. Please find attached a patch for DrawRectangle and DrawBitmap. BTW: text2skin will not benefit from the DrawBitmap changes as it uses it's own copy of DrawBitmap.

Seems that work needs to be done always twice :( I made similar improvements for the Reel-vdr almost two years ago (replacing SetIndex by a faster version without dirty-update). AFAIK RMM also submitted the patches. At that time nobody was interested in them ("vdr is fast enough" or the like).

Hi,

the first patch optimizes cNitFilter::Process() by looping only over the relevant channels. It introduces a further hash in cChannels and implements an iterator for hiding this implementation detail.

The channel_display patch avoids to call DrawText() when the "date" text has not changed in the channel display. As DrawText() calls DrawRectangle() when a non transparent background color was specified, drawing the same text will always yield a dirty area although there is no difference when looking at the bitmap before and after the call to DrawText().

And finally, the formerly released osd_draw patch has been updated a little bit. DrawBitmap() and DrawRectangle() use now memcpy() when possible.

Bye.