At the end of a recording, vdr 1.3.35 (patched with slightly adapted DVBsubs.patch from subtitles-0.3.8 and my suspend patch) crashes repeatably as follows:
#0 0x080f9fe4 in cUnbufferedFile::Seek (this=0x0, Offset=0, Whence=0) at tools.c:884 #1 0x080d268a in cFileName::SetOffset (this=0x8344018, Number=2, Offset=0) at recording.c:1345 #2 0x080d2903 in cFileName::NextFile (this=0x0) at recording.c:1358 #3 0x0809ca0c in cDvbPlayer::NextFile (this=0x8475238, FileNumber=0 '\0', FileOffset=-1) at dvbplayer.c:333 #4 0x0809dc6e in cDvbPlayer::Action (this=0x8475238) at dvbplayer.c:393 #5 0x080f43c2 in cThread::StartThread (Thread=0x8475244) at thread.c:234 #6 0xb7eedcfd in start_thread () from /lib/tls/libpthread.so.0 #7 0xb7d72f1e in clone () from /lib/tls/libc.so.6
This looks like new code in 1.3.35.
BTW, is there a reason why VDR discards the currently displayed menu at the end of a recording?
Marko
Marko Mäkelä wrote:
At the end of a recording, vdr 1.3.35 (patched with slightly adapted DVBsubs.patch from subtitles-0.3.8 and my suspend patch) crashes repeatably as follows:
#0 0x080f9fe4 in cUnbufferedFile::Seek (this=0x0, Offset=0, Whence=0) at tools.c:884
A fix was posted to this list 2 days ago: http://www.linuxtv.org/pipermail/vdr/2005-November/005770.html
Jon
Marko Mäkelä wrote:
... BTW, is there a reason why VDR discards the currently displayed menu at the end of a recording?
Not really, it just arose that way.
This should fix it:
--- vdr.c 2005/10/09 10:01:45 1.218 +++ vdr.c 2005/11/04 13:48:39 @@ -813,8 +813,14 @@ if (Interact) { eOSState state = Interact->ProcessKey(key); if (state == osUnknown && Interact != cControl::Control()) { - if (ISMODELESSKEY(key) && cControl::Control()) + if (ISMODELESSKEY(key) && cControl::Control()) { state = cControl::Control()->ProcessKey(key); + if (state == osEnd) { + // let's not close a menu when replay ends: + cControl::Shutdown(); + continue; + } + } else if (time(NULL) - LastActivity > MENUTIMEOUT) state = osEnd; }
Klaus
On Fri, Nov 04, 2005 at 02:51:01PM +0100, Klaus Schmidinger wrote:
Marko Mäkelä wrote:
... BTW, is there a reason why VDR discards the currently displayed menu at the end of a recording?
Not really, it just arose that way.
This should fix it:
--- vdr.c 2005/10/09 10:01:45 1.218 +++ vdr.c 2005/11/04 13:48:39 @@ -813,8 +813,14 @@ if (Interact) { eOSState state = Interact->ProcessKey(key); if (state == osUnknown && Interact != cControl::Control()) {
if (ISMODELESSKEY(key) && cControl::Control())
if (ISMODELESSKEY(key) && cControl::Control()) { state = cControl::Control()->ProcessKey(key);if (state == osEnd) {// let's not close a menu when replay ends:cControl::Shutdown();continue;}} else if (time(NULL) - LastActivity > MENUTIMEOUT) state = osEnd; }
Thanks! Out of curiosity, I enabled the main menu (the one that shows "stop playback" as the last entry) during playback. The item did not go away when the playback ended. Of course, I had to select that item when softdevice was already showing live program. It went black for a couple of seconds and then resumed playing the live program.
For me, it's just a cosmetic thing. It's very nice that I can play with the menus (such as browse the EPG) while watching a recording that is about to end. However, perhaps someone with a hardware MPEG decoder (FF card or DXR3) should test this patch?
Marko
Marko Mäkelä wrote:
... For me, it's just a cosmetic thing. It's very nice that I can play with the menus (such as browse the EPG) while watching a recording that is about to end. However, perhaps someone with a hardware MPEG decoder (FF card or DXR3) should test this patch?
I have a FF card myself and it works fine here.
Klaus
On Fri, Nov 04, 2005 at 11:03:41PM +0100, Klaus Schmidinger wrote:
Marko Mäkelä wrote:
... For me, it's just a cosmetic thing. It's very nice that I can play with the menus (such as browse the EPG) while watching a recording that is about to end. However, perhaps someone with a hardware MPEG decoder (FF card or DXR3) should test this patch?
I have a FF card myself and it works fine here.
Great! I guess the FF card will just keep playing the live stream when you select the "stop playback" menu item.
Marko
Marko Mäkelä wrote:
On Fri, Nov 04, 2005 at 11:03:41PM +0100, Klaus Schmidinger wrote:
Marko Mäkelä wrote:
... For me, it's just a cosmetic thing. It's very nice that I can play with the menus (such as browse the EPG) while watching a recording that is about to end. However, perhaps someone with a hardware MPEG decoder (FF card or DXR3) should test this patch?
I have a FF card myself and it works fine here.
Great! I guess the FF card will just keep playing the live stream when you select the "stop playback" menu item.
Actually it didn't occur to me to select that option ;-)
I'll try that tomorrow.
Klaus
Klaus Schmidinger wrote:
Marko Mäkelä wrote:
On Fri, Nov 04, 2005 at 11:03:41PM +0100, Klaus Schmidinger wrote:
Marko Mäkelä wrote:
... For me, it's just a cosmetic thing. It's very nice that I can play with the menus (such as browse the EPG) while watching a recording that is about to end. However, perhaps someone with a hardware MPEG decoder (FF card or DXR3) should test this patch?
I have a FF card myself and it works fine here.
Great! I guess the FF card will just keep playing the live stream when you select the "stop playback" menu item.
Actually it didn't occur to me to select that option ;-)
I'll try that tomorrow.
Klaus
Tried it - nothing happens.
I know that this option should be removed when the replay has ended. I'll attend to this when the more important stuff is done...
Klaus
-
Jon Burgess -
Klaus Schmidinger -
Marko Mäkelä