vdr-1.4.3-1.diff epg problems

List overview All Threads
Download

newer

older

A word about anonymity and VDR's...

Simultaneous streams with DVB-C...

V Live

8 Oct 2006 8 Oct '06

9:10 p.m.

I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since the epg guide and vdr-yaepg plugin show "no title" in th epg. Seems that there is an error there. However if I remove the patches to eit.c and eit.h but keep the rest of the patch the epg guide works like it should.

Please see the attached diff the patch that gave the problem.

http://www.geocities.com/vlivecd/vdr-1.4.3-1-eit.diff.zip

Thanks Viking1

--------------------------------- How low will we go? Check out Yahoo! Messengers low PC-to-Phone call rates.

Attachments:

attachment.html (text/html — 688 bytes)

Show replies by date

Klaus Schmidinger

9 Oct 9 Oct

3:58 p.m.

V Live wrote:

...

I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since the epg guide and vdr-yaepg plugin show "no title" in th epg. Seems that there is an error there. However if I remove the patches to eit.c and eit.h but keep the rest of the patch the epg guide works like it should.

Please see the attached diff the patch that gave the problem.

http://www.geocities.com/vlivecd/vdr-1.4.3-1-eit.diff.zip

This change just clears any existing contents in the Title, ShortText or Description if the current version of the event data doesn't contain a ShortEventDescriptor or ExtendedEventDescriptor.

The reason for this is that there are cases where an event e.g. doesn't have an ExtendedEventDescriptor, but has a lengthy text in the ShortText. cEvent::FixEpgBugs() then moves the "ShortText" into the Description and clears the ShortText. If later a new version of the event data is encountered, the ShortText would be set to the lengthy text again, and the Description wouldn't be overwritten, since there is no ExtendedEventDescriptor. cEvent::FixEpgBugs() would then do nothing and the result is an event with (almost) the same text in both ShortText and Description.

So if in your case there are suddenly events with no data at all, this can only mean that the current version of the event data doesn't have a ShortEventDescriptor or ExtendedEventDescriptor. But then I wonder where that data came from before...

I'm afraid I can't further debug this here, because this problem doesn't occur with the data I'm receiving. So I guess you'll have to debug this yourself.

Klaus

Klaus Schmidinger

4:19 p.m.

V Live wrote:

...

I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since the epg guide and vdr-yaepg plugin show "no title" in th epg. Seems that there is an error there. However if I remove the patches to eit.c and eit.h but keep the rest of the patch the epg guide works like it should.

Well, meanwhile I guess I found it. The problem only occurs if there is external EPG data (with table id 0x00). The attached patch should fix that.

Klaus

V Live

11 Oct 11 Oct

1:18 a.m.

Thank you for your effort. But the attached patch still did not fix the "no title" in the epg guide or yaepg plugin. But like I said before removing the eit.c patch from your vdr-1.4.3-1.diff and it works fine.

Klaus Schmidinger Klaus.Schmidinger@cadsoft.de wrote: V Live wrote:

...

I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since the epg guide and vdr-yaepg plugin show "no title" in th epg. Seems that there is an error there. However if I remove the patches to eit.c and eit.h but keep the rest of the patch the epg guide works like it should.

Well, meanwhile I guess I found it. The problem only occurs if there is external EPG data (with table id 0x00). The attached patch should fix that.

Klaus

--- eit.c 2006/10/07 12:32:24 1.121 +++ eit.c 2006/10/09 16:14:36 @@ -234,7 +234,7 @@ pEvent->SetTitle(ShortEventDescriptor->name.getText(buffer, sizeof(buffer))); pEvent->SetShortText(ShortEventDescriptor->text.getText(buffer, sizeof(buffer))); } - else { + else if (!HasExternalData) { pEvent->SetTitle(NULL); pEvent->SetShortText(NULL); } @@ -242,7 +242,7 @@ char buffer[ExtendedEventDescriptors->getMaximumTextLength(": ") + 1]; pEvent->SetDescription(ExtendedEventDescriptors->getText(buffer, sizeof(buffer), ": ")); } - else + else if (!HasExternalData) pEvent->SetDescription(NULL); } delete ExtendedEventDescriptors; @@ -250,7 +250,8 @@

pEvent->SetComponents(Components);

- pEvent->FixEpgBugs(); + if (!HasExternalData) + pEvent->FixEpgBugs(); if (LinkChannels) channel->SetLinkChannels(LinkChannels); Modified = true; _______________________________________________ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

--------------------------------- Get your own web address for just $1.99/1st yr. We'll help. Yahoo! Small Business.

VDR User

1:44 p.m.

I can confirm this as well. Tried the new patch, didn't solve the problem. EIT -1, Klaus - 0 ;)

On 10/10/06, V Live vlivecd@yahoo.com wrote:

...

Thank you for your effort. But the attached patch still did not fix the "no title" in the epg guide or yaepg plugin. But like I said before removing the eit.c patch from your vdr-1.4.3-1.diff and it works fine.

*Klaus Schmidinger Klaus.Schmidinger@cadsoft.de* wrote:

V Live wrote:

...
I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since the epg guide and vdr-yaepg plugin show "no title" in th epg. Seems that

...
there is an error there. However if I remove the patches to eit.c and eit.h but keep the rest of the patch the epg guide works like it should.

Well, meanwhile I guess I found it. The problem only occurs if there is external EPG data (with table id 0x00). The attached patch should fix that.

Klaus

--- eit.c 2006/10/07 12:32:24 1.121 +++ eit.c 2006/10/09 16:14:36 @@ -234,7 +234,7 @@ pEvent->SetTitle(ShortEventDescriptor->name.getText(buffer, sizeof(buffer))); pEvent->SetShortText(ShortEventDescriptor->text.getText(buffer, sizeof(buffer))); }

else {

else if (!HasExternalData) {

pEvent->SetTitle(NULL); pEvent->SetShortText(NULL); } @@ -242,7 +242,7 @@ char buffer[ExtendedEventDescriptors->getMaximumTextLength(": ") + 1]; pEvent->SetDescription(ExtendedEventDescriptors->getText(buffer, sizeof(buffer), ": ")); }

else

else if (!HasExternalData)

pEvent->SetDescription(NULL); } delete ExtendedEventDescriptors; @@ -250,7 +250,8 @@

pEvent->SetComponents(Components);

pEvent->FixEpgBugs();

if (!HasExternalData)

pEvent->FixEpgBugs();

if (LinkChannels) channel->SetLinkChannels(LinkChannels); Modified = true; _______________________________________________ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Get your own web address for just $1.99/1st yr. We'll help. Yahoo! Small Businesshttp://us.rd.yahoo.com/evt=41244/*http://smallbusiness.yahoo.com/.

vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Klaus Schmidinger

14 Oct 14 Oct

9:09 a.m.

VDR User wrote:

...

I can confirm this as well. Tried the new patch, didn't solve the problem. EIT -1, Klaus - 0 ;)

Well, it did solve the problem as far as I was able to reproduce it. I have external EPG for some channels that don't provide more than the "present/following" EPG data, and before the last change I actually had "No title" in all those events on these channels that were actually in their EIT data. After inserting the additional 'if (!HasExternalData)' checks this problem was gone.

Could it be that your extenal EPG data doesn't have 0 (zero) as the table id?

Also note that this fixes the problem only for EPG data that is received *after* the patch has been applied. Any external EPG data that already has a "No title" title won't change back.

Klaus

...

On 10/10/06, *V Live* < vlivecd@yahoo.com mailto:vlivecd@yahoo.com> wrote:

Thank you for your effort. But the attached patch still did not fix
the "no title" in the epg guide or yaepg plugin. But like I said
before removing the eit.c patch from your vdr-1.4.3-1.diff and it
works fine.


*/Klaus Schmidinger < Klaus.Schmidinger@cadsoft.de
<mailto:Klaus.Schmidinger@cadsoft.de>>/* wrote:

    V Live wrote:
    >  I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version
    and since
    >  the epg guide and vdr-yaepg plugin show "no title" in th epg.
    Seems that
    >  there is an error there.
    >  However if I remove the patches to eit.c and eit.h but keep
    the rest of
    >  the patch the epg guide works like it should.

    Well, meanwhile I guess I found it.
    The problem only occurs if there is external EPG data (with
    table id 0x00). The attached patch should fix that.

    Klaus

...

Carlos Javier Borroto

11 Oct 11 Oct

3:16 p.m.

2006/10/10, V Live vlivecd@yahoo.com:

...

Thank you for your effort. But the attached patch still did not fix the "no title" in the epg guide or yaepg plugin. But like I said before removing the eit.c patch from your vdr-1.4.3-1.diff and it works fine.

Are you using vdr with DN and EIT patch for this network?, If you do, I think is important to remark, cause the problem maybe is that this patch is broken by the recent changes may in vdr source, so you should seek help from the author of the patch.

regards Carlos Javier

-- Carlos Javier Linux User #268006 Jabber: cjavier@softwarelibre.cu Habana, CUBA

6532

Age (days ago)

6538

Last active (days ago)

vdr@linuxtv.org

6 comments

4 participants

tags (0)

participants (4)

Carlos Javier Borroto
Klaus Schmidinger
V Live
VDR User